netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: davej@codemonkey.org.uk, netdev@vger.kernel.org
Subject: Re: lockdep trace from rc2.
Date: Tue, 26 Feb 2008 19:51:57 -0800	[thread overview]
Message-ID: <20080226195157.46645a62@extreme> (raw)
In-Reply-To: <20080226.181354.33497295.davem@davemloft.net>

On Tue, 26 Feb 2008 18:13:54 -0800 (PST)
David Miller <davem@davemloft.net> wrote:

> From: Dave Jones <davej@codemonkey.org.uk>
> Date: Sun, 24 Feb 2008 21:22:37 -0500
> 
> > https://bugzilla.redhat.com/show_bug.cgi?id=431038 has some more info,
> > but the trace is below...
> > I'll get an rc3 kernel built and ask the user to retest, but in case this
> > isn't a known problem, I'm forwarding this here.
> 
> So basically, tulip's ->stop() calls tulip_down() which does a
> flush_scheduled_work().
> 
> Lockdep is saying that the RTNL mutex (which is held when we
> call the driver's ->stop() method) conflicts with that work
> queue lock that flush_scheduled_work() takes.
> 
> Maybe this has something to do with how linkwatch works, but
> I can't say that I've seen this before nor do I quite understand
> what lockdep doesn't exactly like here.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

This has come up before in other drivers,
you can't call flush_scheduled_work under RTNL.
See:  http://article.gmane.org/gmane.linux.network/86941

  reply	other threads:[~2008-02-27  3:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-25  2:22 lockdep trace from rc2 Dave Jones
2008-02-25 10:46 ` Johannes Berg
2008-02-27 11:44   ` Johannes Berg
2008-02-27  2:13 ` David Miller
2008-02-27  3:51   ` Stephen Hemminger [this message]
2008-02-27  3:54     ` Stephen Hemminger
2008-02-27  6:40       ` David Miller
2008-02-27 11:40         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080226195157.46645a62@extreme \
    --to=shemminger@vyatta.com \
    --cc=davej@codemonkey.org.uk \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).