From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: lockdep trace from rc2. Date: Tue, 26 Feb 2008 19:51:57 -0800 Message-ID: <20080226195157.46645a62@extreme> References: <20080225022237.GA3907@codemonkey.org.uk> <20080226.181354.33497295.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: davej@codemonkey.org.uk, netdev@vger.kernel.org To: David Miller Return-path: Received: from mail.vyatta.com ([216.93.170.194]:45050 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752390AbYB0DwE (ORCPT ); Tue, 26 Feb 2008 22:52:04 -0500 In-Reply-To: <20080226.181354.33497295.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 26 Feb 2008 18:13:54 -0800 (PST) David Miller wrote: > From: Dave Jones > Date: Sun, 24 Feb 2008 21:22:37 -0500 > > > https://bugzilla.redhat.com/show_bug.cgi?id=431038 has some more info, > > but the trace is below... > > I'll get an rc3 kernel built and ask the user to retest, but in case this > > isn't a known problem, I'm forwarding this here. > > So basically, tulip's ->stop() calls tulip_down() which does a > flush_scheduled_work(). > > Lockdep is saying that the RTNL mutex (which is held when we > call the driver's ->stop() method) conflicts with that work > queue lock that flush_scheduled_work() takes. > > Maybe this has something to do with how linkwatch works, but > I can't say that I've seen this before nor do I quite understand > what lockdep doesn't exactly like here. > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html This has come up before in other drivers, you can't call flush_scheduled_work under RTNL. See: http://article.gmane.org/gmane.linux.network/86941