From: Jarek Poplawski <jarkao2@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: lyw@cn.fujitsu.com, swhiteho@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH] Can not send icmp netunreach packet
Date: Tue, 26 Feb 2008 23:44:38 +0100 [thread overview]
Message-ID: <20080226224438.GA19937@ami.dom.local> (raw)
In-Reply-To: <20080226.133030.147637482.davem@davemloft.net>
On Tue, Feb 26, 2008 at 01:30:30PM -0800, David Miller wrote:
> From: Jarek Poplawski <jarkao2@gmail.com>
> Date: Tue, 26 Feb 2008 07:35:38 +0000
>
> > On 26-02-2008 07:34, Li Yewang wrote:
> > > Hi All
> > >
> > > There is a bug about icmp netunreach.
> > > If the kernel does not find a route for a packet,
> > > it must send a icmp netunreach packet to the source host,
> > > and discard the packet. But the kernel does not send
> > > a icmp netunreach packet because of the fib_lookup
> > > return value of -ESRCH when a route is not found.
> >
> > ...or because some function doesn't handle -ESRCH return from
> > fib_lookup? It seems changing this to -ESRCH was needed in some cases.
> > And you don't explain enough why it can't be handled later (like in
> > ipv4/route.c: ip_route_input_slow)?
>
> This was changed to -ESRCH so that the proper statistics
> would be bumped. So if we change it back, the statistics
> will be broken again.
Actually, I liked more this sophisticated explanation from the changelog:
http://git.kernel.org/?p=linux/kernel/git/davem/net-2.6.git;a=commitdiff;h=83886b6b636173b206f475929e58fac75c6f2446
BTW, it's really hard to find any place which could still behave as
described by Li. Wasn't it with some older kernel?
Jarek P.
prev parent reply other threads:[~2008-02-26 22:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-26 6:34 [PATCH] Can not send icmp netunreach packet Li Yewang
2008-02-26 7:35 ` Jarek Poplawski
2008-02-26 9:59 ` Wei Yongjun
2008-02-26 10:55 ` Jarek Poplawski
2008-02-26 15:34 ` Stephen Hemminger
2008-02-26 21:30 ` David Miller
2008-02-26 22:44 ` Jarek Poplawski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080226224438.GA19937@ami.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=lyw@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).