From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Subject: Re: [2.6 patch] selinux/netlabel.c should #include "netlabel.h" Date: Wed, 27 Feb 2008 17:08:04 -0500 Message-ID: <200802271708.04766.paul.moore@hp.com> References: <20080227212042.GK29269@cs181133002.pp.htv.fi> <200802271642.57556.paul.moore@hp.com> <20080227215543.GW29269@cs181133002.pp.htv.fi> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: sds@tycho.nsa.gov, jmorris@namei.org, eparis@parisplace.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Adrian Bunk Return-path: Received: from g1t0027.austin.hp.com ([15.216.28.34]:25310 "EHLO g1t0027.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756202AbYB0WIG (ORCPT ); Wed, 27 Feb 2008 17:08:06 -0500 In-Reply-To: <20080227215543.GW29269@cs181133002.pp.htv.fi> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: On Wednesday 27 February 2008 4:55:43 pm Adrian Bunk wrote: > On Wed, Feb 27, 2008 at 04:42:57PM -0500, Paul Moore wrote: > > On Wednesday 27 February 2008 4:20:42 pm Adrian Bunk wrote: > > > Every file should include the headers containing the externs for > > > its global code. > > > > > > Signed-off-by: Adrian Bunk > > > > It doesn't _need_ the file in the strictest sense, the header file > > is just there for the core SELinux code to call into the > > NetLabel/SELinux glue code (what is in > > security/selinux/netlabel.c). However, if this is to conform > > better to kernel coding policy (I assume that is the case here?) > > then that is fine with me. > > I'm not claiming it needs it. > > But with this #include gcc can check that the prototypes in > netlabel.h match the functions in netlabel.c > > The bugs this catches are rare, but when you have such a bug it can > be nasty to debug. Good point, hadn't thought of that - thanks. > > Acked-by: Paul Moore -- paul moore linux security @ hp