From: David Miller <davem@davemloft.net>
To: wangchen@cn.fujitsu.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 03/15] [SUNRPC]: Use proc_create() to setup ->proc_fops first
Date: Thu, 28 Feb 2008 14:02:22 -0800 (PST) [thread overview]
Message-ID: <20080228.140222.07061140.davem@davemloft.net> (raw)
In-Reply-To: <47C6932C.90907@cn.fujitsu.com>
From: Wang Chen <wangchen@cn.fujitsu.com>
Date: Thu, 28 Feb 2008 18:55:40 +0800
> Use proc_create() to make sure that ->proc_fops be setup before gluing
> PDE to main tree.
>
> Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Applied.
> @@ -229,9 +229,8 @@ do_register(const char *name, void *data, const struct file_operations *fops)
> rpc_proc_init();
> dprintk("RPC: registering /proc/net/rpc/%s\n", name);
>
> - ent = create_proc_entry(name, 0, proc_net_rpc);
> + ent = proc_create(name, 0, proc_net_rpc, fops);
> if (ent) {
> - ent->proc_fops = fops;
> ent->data = data;
> }
> return ent;
For this case it appears that ent->data has the same kind of
visibility problem that ent->proc_fops does.
next prev parent reply other threads:[~2008-02-28 22:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-28 10:55 [PATCH 03/15] [SUNRPC]: Use proc_create() to setup ->proc_fops first Wang Chen
2008-02-28 22:02 ` David Miller [this message]
2008-02-29 5:26 ` Wang Chen
2008-02-29 8:35 ` Wang Chen
2008-02-29 9:32 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080228.140222.07061140.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).