From: David Miller <davem@davemloft.net>
To: wangchen@cn.fujitsu.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 14/15] [WANROUTER]: Use proc_create() to setup ->proc_fops first
Date: Thu, 28 Feb 2008 14:16:11 -0800 (PST) [thread overview]
Message-ID: <20080228.141611.43422202.davem@davemloft.net> (raw)
In-Reply-To: <47C693DB.7040002@cn.fujitsu.com>
From: Wang Chen <wangchen@cn.fujitsu.com>
Date: Thu, 28 Feb 2008 18:58:35 +0800
> Use proc_create() to make sure that ->proc_fops be setup before gluing
> PDE to main tree.
>
> Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Applied.
> @@ -329,10 +327,10 @@ int wanrouter_proc_add(struct wan_device* wandev)
> if (wandev->magic != ROUTER_MAGIC)
> return -EINVAL;
>
> - wandev->dent = create_proc_entry(wandev->name, S_IRUGO, proc_router);
> + wandev->dent = proc_create(wandev->name, S_IRUGO,
> + proc_router, &wandev_fops);
> if (!wandev->dent)
> return -ENOMEM;
> - wandev->dent->proc_fops = &wandev_fops;
> wandev->dent->data = wandev;
> return 0;
> }
->data visibility issue
prev parent reply other threads:[~2008-02-28 22:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-28 10:58 [PATCH 14/15] [WANROUTER]: Use proc_create() to setup ->proc_fops first Wang Chen
2008-02-28 22:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080228.141611.43422202.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).