From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: Leandro Sales <leandroal@gmail.com>
Cc: acme@redhat.com, dccp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 3/4] [CCID2]: Replace broken RTT estimator with better algorithm
Date: Thu, 28 Feb 2008 09:53:33 +0000 [thread overview]
Message-ID: <20080228095333.GA4730@gerrit.erg.abdn.ac.uk> (raw)
In-Reply-To: <5bc4c4570802271840t2b3b12a1k260d1e2d7440bdb2@mail.gmail.com>
| > + * Decay RTTVAR at most once per flight, exploiting that
| > + * 1) pipe <= cwnd <= Sequence_Window = W (RFC 4340, 7.5.2)
| > + * 2) AWL = GSS-W+1 <= GAR <= GSS (RFC 4340, 7.5.1)
| > + * GAR is a useful bound for FlightSize = pipe, AWL is probably
| > + * too low as it over-estimates pipe.
| > + */
| > + if (after48(dccp_sk(sk)->dccps_gar, hctx->ccid2hctx_rtt_seq)) {
| > + if (hctx->ccid2hctx_mdev_max < hctx->ccid2hctx_rttvar)
| > + hctx->ccid2hctx_rttvar -= (hctx->ccid2hctx_rttvar - hctx->ccid2hctx_mdev_max) >> 2;
|
| More than 80 chars in this line! 87 chars. Is this ok?
|
There are actually 120 characters in this line. The 80-characters constraint
has become a recommendation, i.e. it is possible and legal to make exceptions.
I kept it in to allow a better comparison to the original TCP code.
If anything, it shows how the ubiquitous `hctx->ccid?hctx_' prefixes make
it hard to read the code.
prev parent reply other threads:[~2008-02-28 9:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 14:23 [DCCP] [Patch 0/4]: Further CCID-2 clean-ups Gerrit Renker
2008-02-27 14:23 ` [PATCH 1/4] [CCID2]: Remove redundant sanity tests Gerrit Renker
2008-02-27 14:23 ` [PATCH 2/4] [CCID2]: Simplify dec_pipe and rearming of RTO timer Gerrit Renker
2008-02-27 14:23 ` [PATCH 3/4] [CCID2]: Replace broken RTT estimator with better algorithm Gerrit Renker
2008-02-27 14:23 ` [PATCH 4/4] [CCID2]: Remove wrappers around sk_{reset,stop}_timer() Gerrit Renker
2008-02-28 2:40 ` [PATCH 3/4] [CCID2]: Replace broken RTT estimator with better algorithm Leandro Sales
2008-02-28 9:53 ` Gerrit Renker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080228095333.GA4730@gerrit.erg.abdn.ac.uk \
--to=gerrit@erg.abdn.ac.uk \
--cc=acme@redhat.com \
--cc=dccp@vger.kernel.org \
--cc=leandroal@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).