[PATCH 1/2] [SCTP]: Kill unused static inline sctp_sysctl_jiffies_ms

[PATCH 1/2] [SCTP]: Kill unused static inline sctp_sysctl_jiffies_ms

[Ilpo Järvinen]

After the patch:
$ git-grep sctp_sysctl_jiffies_ms | wc -l
0

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Cc: Vlad Yasevich <vladislav.yasevich@hp.com>
---
 include/net/sctp/sctp.h |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/include/net/sctp/sctp.h b/include/net/sctp/sctp.h
index 57df27f..a653eb3 100644
--- a/include/net/sctp/sctp.h
+++ b/include/net/sctp/sctp.h
@@ -368,11 +368,6 @@ void sctp_sysctl_unregister(void);
 #else
 static inline void sctp_sysctl_register(void) { return; }
 static inline void sctp_sysctl_unregister(void) { return; }
-static inline int sctp_sysctl_jiffies_ms(ctl_table *table, int __user *name, int nlen,
-		void __user *oldval, size_t __user *oldlenp,
-		void __user *newval, size_t newlen) {
-	return -ENOSYS;
-}
 #endif
 
 /* Size of Supported Address Parameter for 'x' address types. */
-- 
1.5.2.2

[PATCH 2/2] [LLC]: Kill static inline llc_addrany

[Ilpo Järvinen]

After the patch:
$ git-grep llc_addrany | wc -l
0

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
---
 include/net/llc_if.h |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/include/net/llc_if.h b/include/net/llc_if.h
index c608812..b595a00 100644
--- a/include/net/llc_if.h
+++ b/include/net/llc_if.h
@@ -74,11 +74,6 @@ static inline int llc_mac_null(const u8 *mac)
 	return is_zero_ether_addr(mac);
 }
 
-static inline int llc_addrany(const struct llc_addr *addr)
-{
-	return llc_mac_null(addr->mac) && !addr->lsap;
-}
-
 static inline int llc_mac_multicast(const u8 *mac)
 {
 	return is_multicast_ether_addr(mac);
-- 
1.5.2.2

Re: [PATCH 2/2] [LLC]: Kill static inline llc_addrany

[Arnaldo Carvalho de Melo]

Em Fri, Feb 29, 2008 at 06:13:16PM +0200, Ilpo Järvinen escreveu:
> After the patch:
> $ git-grep llc_addrany | wc -l
> 0
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
> Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Re: [PATCH 1/2] [SCTP]: Kill unused static inline sctp_sysctl_jiffies_ms

[Vlad Yasevich]

Ilpo Järvinen wrote:
> After the patch:
> $ git-grep sctp_sysctl_jiffies_ms | wc -l
> 0
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
> Cc: Vlad Yasevich <vladislav.yasevich@hp.com>

Good catch.  Looks like dead declaration.

Acked-by: Vlad Yasevich <vladislav.yasevich@hp.com>

Thanks
-vlad

> ---
>  include/net/sctp/sctp.h |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/include/net/sctp/sctp.h b/include/net/sctp/sctp.h
> index 57df27f..a653eb3 100644
> --- a/include/net/sctp/sctp.h
> +++ b/include/net/sctp/sctp.h
> @@ -368,11 +368,6 @@ void sctp_sysctl_unregister(void);
>  #else
>  static inline void sctp_sysctl_register(void) { return; }
>  static inline void sctp_sysctl_unregister(void) { return; }
> -static inline int sctp_sysctl_jiffies_ms(ctl_table *table, int __user *name, int nlen,
> -		void __user *oldval, size_t __user *oldlenp,
> -		void __user *newval, size_t newlen) {
> -	return -ENOSYS;
> -}
>  #endif
>  
>  /* Size of Supported Address Parameter for 'x' address types. */

Re: [PATCH 1/2] [SCTP]: Kill unused static inline sctp_sysctl_jiffies_ms

[David Miller]

From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Fri, 29 Feb 2008 12:09:45 -0500

> Ilpo Järvinen wrote:
> > After the patch:
> > $ git-grep sctp_sysctl_jiffies_ms | wc -l
> > 0
> > 
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
> > Cc: Vlad Yasevich <vladislav.yasevich@hp.com>
> 
> Good catch.  Looks like dead declaration.
> 
> Acked-by: Vlad Yasevich <vladislav.yasevich@hp.com>

Applied to net-2.6.26, thanks everyone.

Re: [PATCH 2/2] [LLC]: Kill static inline llc_addrany

[David Miller]

From: Arnaldo Carvalho de Melo <acme@redhat.com>
Date: Fri, 29 Feb 2008 13:28:33 -0300

> Em Fri, Feb 29, 2008 at 06:13:16PM +0200, Ilpo Järvinen escreveu:
> > After the patch:
> > $ git-grep llc_addrany | wc -l
> > 0
> > 
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
> > Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Also applied, thanks.