From: David Miller <davem@davemloft.net>
To: den@openvz.org
Cc: netdev@vger.kernel.org, YOSHIFUJI@sw.ru
Subject: Re: [PATCH 3/4 net-2.6.26] [SCTP]: seq_printf format warning. (fixed)
Date: Mon, 03 Mar 2008 11:56:53 -0800 (PST) [thread overview]
Message-ID: <20080303.115653.237789682.davem@davemloft.net> (raw)
In-Reply-To: <1204566818-23881-1-git-send-email-den@openvz.org>
From: "Denis V. Lunev" <den@openvz.org>
Date: Mon, 3 Mar 2008 20:53:38 +0300
> sctp_association->hbinterval is unsigned long. Replace %8d with %8ld.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
...
> diff --git a/net/sctp/proc.c b/net/sctp/proc.c
> index 82bea30..138ab5f 100644
> --- a/net/sctp/proc.c
> +++ b/net/sctp/proc.c
> @@ -325,7 +325,7 @@ static int sctp_assocs_seq_show(struct seq_file *seq, void *v)
> seq_printf(seq,
> "%8p %8p %-3d %-3d %-2d %-4d "
> "%4d %8d %8d %7d %5lu %-5d %5d "
> - "%8d %5d %5d %4d %4d %4d %8d ",
> + "%8lu %5d %5d %4d %4d %4d %8d ",
> assoc, sk, sctp_sk(sk)->type, sk->sk_state,
> assoc->state, hash,
> assoc->assoc_id,
Haste makes waste.
You fixed up the patch but didn't update the changelog entry. I've
fixed it up, but please just take your time when respinning patches to
avoid errors like this. It is not a race, and you will not be timed.
next prev parent reply other threads:[~2008-03-03 19:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-03 15:48 [PATCH 1/4 net-2.6.26] [IPV4]: skb->dst can't be NULL in ip_options_echo Denis V. Lunev
2008-03-03 15:48 ` [PATCH 2/4 net-2.6.26] [IPV4]: Cleanup ip_options_compile Denis V. Lunev
2008-03-03 19:55 ` David Miller
2008-03-03 20:54 ` Denis V. Lunev
2008-03-03 21:24 ` David Miller
2008-03-03 22:57 ` Denis V. Lunev
2008-03-03 23:02 ` David Miller
2008-03-03 15:48 ` [PATCH 3/4 net-2.6.26] [SCTP]: seq_printf format warning Denis V. Lunev
2008-03-03 17:39 ` YOSHIFUJI Hideaki / 吉藤英明
2008-03-03 17:53 ` [PATCH 3/4 net-2.6.26] [SCTP]: seq_printf format warning. (fixed) Denis V. Lunev
2008-03-03 19:56 ` David Miller [this message]
2008-03-03 18:41 ` [PATCH 3/4 net-2.6.26] [SCTP]: seq_printf format warning Vlad Yasevich
2008-03-03 15:48 ` [PATCH 4/4 net-2.6.26] [TCP]: Merge exit paths in tcp_v4_conn_request Denis V. Lunev
2008-03-03 19:59 ` David Miller
2008-03-03 19:50 ` [PATCH 1/4 net-2.6.26] [IPV4]: skb->dst can't be NULL in ip_options_echo David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080303.115653.237789682.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=YOSHIFUJI@sw.ru \
--cc=den@openvz.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).