From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: shemminger@vyatta.com, dcbw@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH] New driver "sfc" for Solarstorm SFC4000 controller (try #7)
Date: Mon, 03 Mar 2008 13:29:41 -0800 (PST) [thread overview]
Message-ID: <20080303.132941.176565936.davem@davemloft.net> (raw)
In-Reply-To: <20080303211743.GG2988@solarflare.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 3 Mar 2008 21:17:44 +0000
> It's not a simple device. There are callbacks into MAC-, PHY- and
> board-specific code because this code supports several of each. I
> spent some weeks ruthlessly paring away unnecessary abstraction and
> cruft, and I don't believe there is a significant amount left.
That is your opinion.
We have drivers that handle 30 or so variants of a particular
ethernet chipset and they are not nearly so huge as this
driver, and some of those cases don't have firmware either.
The driver needs to be reviewed on at least some level, but nobody is
going to walk through a 700K driver. And I do mean nobody.
You have to find a way to trim this driver down and make it
more reviewable.
If I can write a full 10Gbit driver in ~11,000 lines of code
(~200,000 bytes), so can anyone else.
next prev parent reply other threads:[~2008-03-03 21:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-03 18:56 [PATCH] New driver "sfc" for Solarstorm SFC4000 controller (try #7) Ben Hutchings
2008-03-03 18:58 ` Ben Hutchings
2008-03-03 19:02 ` David Miller
2008-03-03 19:22 ` Dan Williams
2008-03-03 20:39 ` Stephen Hemminger
2008-03-03 21:17 ` Ben Hutchings
2008-03-03 21:29 ` David Miller [this message]
2008-03-05 14:22 ` Ben Hutchings
2008-03-05 18:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080303.132941.176565936.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=dcbw@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).