From: Alexey Dobriyan <adobriyan@sw.ru>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, den@openvz.org
Subject: [PATCH v2] ipv6: fix icmpv6_cleanup/icmpv6_init section mismatch
Date: Mon, 3 Mar 2008 17:54:51 +0300 [thread overview]
Message-ID: <20080303145451.GC6026@localhost.sw.ru> (raw)
In-Reply-To: <20080303125217.GA6026@localhost.sw.ru>
On Mon, Mar 03, 2008 at 03:52:17PM +0300, Alexey Dobriyan wrote:
> icmpv6_cleanup() is called from inet6_init() which is __init, so the
> former can't be __exit.
Doh! Ignore this one. Below is correct.
--------
[PATCH] ipv6: fix inet6_init/icmpv6_cleanup sections mismatch
Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
---
net/ipv6/icmp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/net/ipv6/icmp.c
+++ b/net/ipv6/icmp.c
@@ -844,7 +844,7 @@ static void __net_exit icmpv6_sk_exit(struct net *net)
kfree(net->ipv6.icmp_sk);
}
-static struct pernet_operations __net_initdata icmpv6_sk_ops = {
+static struct pernet_operations icmpv6_sk_ops = {
.init = icmpv6_sk_init,
.exit = icmpv6_sk_exit,
};
@@ -868,7 +868,7 @@ fail:
return err;
}
-void __exit icmpv6_cleanup(void)
+void icmpv6_cleanup(void)
{
unregister_pernet_subsys(&icmpv6_sk_ops);
inet6_del_protocol(&icmpv6_protocol, IPPROTO_ICMPV6);
next prev parent reply other threads:[~2008-03-03 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-03 12:52 ipv6: fix icmpv6_cleanup/icmpv6_init section mismatch Alexey Dobriyan
2008-03-03 14:54 ` Alexey Dobriyan [this message]
2008-03-03 20:03 ` [PATCH v2] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080303145451.GC6026@localhost.sw.ru \
--to=adobriyan@sw.ru \
--cc=davem@davemloft.net \
--cc=den@openvz.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).