* [patch 2/2] bluetooth: make bnep_sock_cleanup() return void
@ 2008-03-04 23:18 akpm
2008-03-05 8:51 ` Marcel Holtmann
2008-03-06 2:47 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: akpm @ 2008-03-04 23:18 UTC (permalink / raw)
To: davem; +Cc: marcel, hidave.darkstar, netdev, linux-bluetooth, akpm, tklauser
From: Tobias Klauser <tklauser@distanz.ch>
bnep_sock_cleanup() always returns 0 and its return value isn't used
anywhere in the code.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: Dave Young <hidave.darkstar@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
net/bluetooth/bnep/bnep.h | 2 +-
net/bluetooth/bnep/sock.c | 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
diff -puN net/bluetooth/bnep/bnep.h~bluetooth-make-bnep_sock_cleanup-return-void net/bluetooth/bnep/bnep.h
--- a/net/bluetooth/bnep/bnep.h~bluetooth-make-bnep_sock_cleanup-return-void
+++ a/net/bluetooth/bnep/bnep.h
@@ -174,7 +174,7 @@ struct bnep_session {
void bnep_net_setup(struct net_device *dev);
int bnep_sock_init(void);
-int bnep_sock_cleanup(void);
+void bnep_sock_cleanup(void);
static inline int bnep_mc_hash(__u8 *addr)
{
diff -puN net/bluetooth/bnep/sock.c~bluetooth-make-bnep_sock_cleanup-return-void net/bluetooth/bnep/sock.c
--- a/net/bluetooth/bnep/sock.c~bluetooth-make-bnep_sock_cleanup-return-void
+++ a/net/bluetooth/bnep/sock.c
@@ -257,12 +257,10 @@ error:
return err;
}
-int __exit bnep_sock_cleanup(void)
+void __exit bnep_sock_cleanup(void)
{
if (bt_sock_unregister(BTPROTO_BNEP) < 0)
BT_ERR("Can't unregister BNEP socket");
proto_unregister(&bnep_proto);
-
- return 0;
}
_
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch 2/2] bluetooth: make bnep_sock_cleanup() return void
2008-03-04 23:18 [patch 2/2] bluetooth: make bnep_sock_cleanup() return void akpm
@ 2008-03-05 8:51 ` Marcel Holtmann
2008-03-06 2:47 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2008-03-05 8:51 UTC (permalink / raw)
To: akpm; +Cc: davem, hidave.darkstar, netdev, linux-bluetooth, tklauser
Hi Andrew,
> From: Tobias Klauser <tklauser@distanz.ch>
>
> bnep_sock_cleanup() always returns 0 and its return value isn't used
> anywhere in the code.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> Cc: Marcel Holtmann <marcel@holtmann.org>
> Cc: Dave Young <hidave.darkstar@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Dave, I can queue these up if you don't wanna grab them into netdev
tree by yourself.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 2/2] bluetooth: make bnep_sock_cleanup() return void
2008-03-04 23:18 [patch 2/2] bluetooth: make bnep_sock_cleanup() return void akpm
2008-03-05 8:51 ` Marcel Holtmann
@ 2008-03-06 2:47 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2008-03-06 2:47 UTC (permalink / raw)
To: akpm; +Cc: marcel, hidave.darkstar, netdev, linux-bluetooth, tklauser
From: akpm@linux-foundation.org
Date: Tue, 04 Mar 2008 15:18:24 -0800
> From: Tobias Klauser <tklauser@distanz.ch>
>
> bnep_sock_cleanup() always returns 0 and its return value isn't used
> anywhere in the code.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> Cc: Marcel Holtmann <marcel@holtmann.org>
> Cc: Dave Young <hidave.darkstar@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-03-06 2:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-04 23:18 [patch 2/2] bluetooth: make bnep_sock_cleanup() return void akpm
2008-03-05 8:51 ` Marcel Holtmann
2008-03-06 2:47 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).