From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org
Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
hidave.darkstar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
alon.barlev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
seife-l3A5Bk7waGM@public.gmane.org
Subject: Re: [patch (for 2.6.25?) 1/2] bluetooth: hci_core: defer hci_unregister_sysfs()
Date: Wed, 05 Mar 2008 18:46:17 -0800 (PST) [thread overview]
Message-ID: <20080305.184617.42952396.davem@davemloft.net> (raw)
In-Reply-To: <1250A009-2EDE-4203-9472-05F68BC66001-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
From: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
Date: Wed, 5 Mar 2008 09:48:29 +0100
> > @@ -902,8 +902,6 @@ int hci_unregister_dev(struct hci_dev *h
> >
> > BT_DBG("%p name %s type %d", hdev, hdev->name, hdev->type);
> >
> > - hci_unregister_sysfs(hdev);
> > -
> > write_lock_bh(&hci_dev_list_lock);
> > list_del(&hdev->list);
> > write_unlock_bh(&hci_dev_list_lock);
> > @@ -915,6 +913,8 @@ int hci_unregister_dev(struct hci_dev *h
> >
> > hci_notify(hdev, HCI_DEV_UNREG);
> >
> > + hci_unregister_sysfs(hdev);
> > +
> > __hci_dev_put(hdev);
>
> I never got a chance to test this one in a proper way, but from a
> logic point of view it makes sense and thus it is acked by me. I also
> trust Stefan that he fully tested it.
Also applied to net-2.6
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-03-06 2:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 22:58 [patch (for 2.6.25?) 1/2] bluetooth: hci_core: defer hci_unregister_sysfs() akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b
2008-03-05 8:48 ` Marcel Holtmann
[not found] ` <1250A009-2EDE-4203-9472-05F68BC66001-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2008-03-05 9:04 ` Stefan Seyfried
2008-03-06 2:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080305.184617.42952396.davem@davemloft.net \
--to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=alon.barlev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=hidave.darkstar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=seife-l3A5Bk7waGM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).