From: David Miller <davem@davemloft.net>
To: panther@balabit.hu
Cc: netdev@vger.kernel.org
Subject: Re: [PATCHv8 1/2] Interface group: core and netlink part
Date: Thu, 06 Mar 2008 11:15:19 -0800 (PST) [thread overview]
Message-ID: <20080306.111519.46454329.davem@davemloft.net> (raw)
In-Reply-To: <1204812239968-git-send-email-panther@balabit.hu>
From: Laszlo Attila Toth <panther@balabit.hu>
Date: Thu, 6 Mar 2008 15:03:58 +0100
> Interface groups let handle different interfaces together.
> Modified net device structure and netlink interface.
>
> Signed-off-by: Laszlo Attila Toth <panther@balabit.hu>
I can't say whether this makes sense without seeing how
it will actually be used.
And both of your patches here do nothing but set and
read this group value, making it useless.
If that's all it is, userland can record such mappings
in the filesystem or elsewhere such that multiple
applications can work with and maintain the relationships.
There is zero reason to add this bloat to the kernel in
such a case.
next prev parent reply other threads:[~2008-03-06 19:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 14:02 [PATCHv8 0/2] Interface group patches, take 8 Laszlo Attila Toth
2008-03-06 14:03 ` [PATCHv8 1/2] Interface group: core and netlink part Laszlo Attila Toth
2008-03-06 19:15 ` David Miller [this message]
2008-03-07 12:40 ` Laszlo Attila Toth
2008-04-03 20:35 ` David Miller
2008-03-06 14:03 ` [PATCHv8 2/2] Ifgroup read/write support in sysfs Laszlo Attila Toth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080306.111519.46454329.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=panther@balabit.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).