From: Andrew Morton <akpm@linux-foundation.org>
To: "Kok, Auke" <auke-jan.h.kok@intel.com>
Cc: jeff@garzik.org, netdev@vger.kernel.org, jkschind@gmail.com,
alan@lxorguk.ukuu.org.uk
Subject: Re: [patch 16/17] drivers/net/8390.c: replace init_module&cleanup_module with module_init&module_exit
Date: Mon, 10 Mar 2008 11:58:42 -0700 [thread overview]
Message-ID: <20080310115842.8b2ca9fd.akpm@linux-foundation.org> (raw)
In-Reply-To: <47D1D70A.2070003@intel.com>
On Fri, 07 Mar 2008 16:00:10 -0800
"Kok, Auke" <auke-jan.h.kok@intel.com> wrote:
> akpm@linux-foundation.org wrote:
> > From: Jon Schindler <jkschind@gmail.com>
> >
> > Replace init_module and cleanup_module with static functions and
> > module_init/module_exit.
> >
> > Signed-off-by: Jon Schindler <jkschind@gmail.com>
> > Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>
> something went wrong here as this patch already appears to be in jeff's upstream
> tree as commit 8724c2de65fe527f5b7aa662fcb8573fb8cd02f2, but breaks compile.
>
> with CONFIG_NE2K_PCI=m:
>
> CC [M] drivers/net/8390.o
> drivers/net/8390.c: In function '__inittest':
> drivers/net/8390.c:60: error: 'ns8390_init_module' undeclared (first use in this
> function)
> drivers/net/8390.c:60: error: (Each undeclared identifier is reported only once
> drivers/net/8390.c:60: error: for each function it appears in.)
> make[2]: *** [drivers/net/8390.o] Error 1
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2
>
>
> reverting the patch fixes the issue, but better would be to fix.
>
> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
> Cc: Jon Schindler <jkschind@gmail.com>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Cc: Andrew Morton <akpm@linux-foundation.org>
>
> ---
> diff --git a/drivers/net/8390.c b/drivers/net/8390.c
> index 0ed41a3..a499e86 100644
> --- a/drivers/net/8390.c
> +++ b/drivers/net/8390.c
> @@ -57,7 +57,7 @@ static void __exit ns8390_module_exit(void)
> {
> }
>
> -module_init(ns8390_init_module);
> +module_init(ns8390_module_init);
> module_exit(ns8390_module_exit);
> #endif /* MODULE */
> MODULE_LICENSE("GPL");
OK, thanks, I'll drop it.
next prev parent reply other threads:[~2008-03-10 18:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 23:19 [patch 16/17] drivers/net/8390.c: replace init_module&cleanup_module with module_init&module_exit akpm
2008-03-08 0:00 ` Kok, Auke
2008-03-09 6:56 ` Jon Schindler
2008-03-09 7:00 ` Jon Schindler
2008-03-10 18:58 ` Andrew Morton [this message]
2008-03-20 18:15 ` Kok, Auke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080310115842.8b2ca9fd.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=auke-jan.h.kok@intel.com \
--cc=jeff@garzik.org \
--cc=jkschind@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).