netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	alan@lxorguk.ukuu.org.uk, jgarzik <jgarzik@pobox.com>
Subject: Re: [PATCH -mm] ne2: needs more 8390 support functions
Date: Tue, 11 Mar 2008 21:51:10 -0700	[thread overview]
Message-ID: <20080311215110.5215cc4d.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080311095643.01cd3708.randy.dunlap@oracle.com>

On Tue, 11 Mar 2008 09:56:43 -0700 Randy Dunlap <randy.dunlap@oracle.com> wrote:

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> ne2 (MCA) needs both 8390.o and 8390p.o functions:
> 
> drivers/built-in.o: In function `ne_close':
> ne2.c:(.text+0x30544): undefined reference to `eip_close'
> drivers/built-in.o: In function `ne_open':
> ne2.c:(.text+0x30554): undefined reference to `eip_open'
> drivers/built-in.o: In function `ne2_probe':
> (.init.text+0x1bce): undefined reference to `__alloc_eip_netdev'
> drivers/built-in.o: In function `ne2_probe':
> (.init.text+0x1dd9): undefined reference to `eip_interrupt'
> make[1]: *** [.tmp_vmlinux1] Error 1
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  drivers/net/Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2.6.25-rc5-mm1.orig/drivers/net/Makefile
> +++ linux-2.6.25-rc5-mm1/drivers/net/Makefile
> @@ -108,7 +108,7 @@ obj-$(CONFIG_68360_ENET) += 68360enet.o
>  obj-$(CONFIG_WD80x3) += wd.o 8390.o
>  obj-$(CONFIG_EL2) += 3c503.o 8390p.o
>  obj-$(CONFIG_NE2000) += ne.o 8390p.o
> -obj-$(CONFIG_NE2_MCA) += ne2.o 8390.o
> +obj-$(CONFIG_NE2_MCA) += ne2.o 8390.o 8390p.o
>  obj-$(CONFIG_HPLAN) += hp.o 8390p.o
>  obj-$(CONFIG_HPLAN_PLUS) += hp-plus.o 8390p.o
>  obj-$(CONFIG_ULTRA) += smc-ultra.o 8390.o

I have a note here that there's something busted about
8390-split-8390-support-into-a-pausing-and-a-non-pausing-driver-core.patch
but I do not recall what it was.  The details languish in Alan's inbox
somewhere from around February.

I wonder if this was it, and if that was the only bug.

  reply	other threads:[~2008-03-12  4:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-11 16:56 [PATCH -mm] ne2: needs more 8390 support functions Randy Dunlap
2008-03-12  4:51 ` Andrew Morton [this message]
2008-03-12 12:44 ` Alan Cox
2008-03-12 15:08   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080311215110.5215cc4d.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).