From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: ramirose@gmail.com, davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
yoshfuji@linux-ipv6.org
Subject: Re: [PATCH] [IPV6] remove unused parameter (struct sock parameter) from ip6_route_output()
Date: Tue, 18 Mar 2008 18:15:55 +0900 (JST) [thread overview]
Message-ID: <20080318.181555.105003756.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <eb3ff54b0803180203h18cda4ceja6ae28033638d338@mail.gmail.com>
NAK; I have a plan to use it in net-2.6.26 tree.
--yoshfuji
In article <eb3ff54b0803180203h18cda4ceja6ae28033638d338@mail.gmail.com> (at Tue, 18 Mar 2008 11:03:04 +0200), "Rami Rosen" <ramirose@gmail.com> says:
> Hi,
> This patch removes the struct sock parameter from ip6_route_output();
> looking at the ip6_route_output() implementation in net/ipv6/route.c
> will show immediately that it is not used in this method.
>
> In fact, icmp.c and ip6_output.c are the only places in the kernel
> where the sk (struct sock) parameter passed to ip6_route_output() is not NULL;
> anyhow, as explained above, this parameter is unused; changing
> the ip6_route_output() prototype by omitting the struct sock parameter
> does not break anything.
>
>
> Regards,
> Rami Rosen
>
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
prev parent reply other threads:[~2008-03-18 9:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-18 9:03 [PATCH] [IPV6] remove unused parameter (struct sock parameter) from ip6_route_output() Rami Rosen
2008-03-18 9:15 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080318.181555.105003756.yoshfuji@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ramirose@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox