From: David Miller <davem@davemloft.net>
To: vladislav.yasevich@hp.com
Cc: netdev@vger.kernel.org, lksctp-developers@lists.sourceforge.net
Subject: Re: [PATCH]: [SCTP]: Fix a race between module load and protosw access
Date: Thu, 20 Mar 2008 15:18:54 -0700 (PDT) [thread overview]
Message-ID: <20080320.151854.41734345.davem@davemloft.net> (raw)
In-Reply-To: <47E2670C.1040900@hp.com>
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Thu, 20 Mar 2008 09:30:52 -0400
> There is a race is SCTP between the loading of the module
> and the access by the socket layer to the protocol functions.
> In particular, a list of addresss that SCTP maintains is
> not initialized prior to the registration with the protosw.
> Thus it is possible for a user application to gain access
> to SCTP functions before everything has been initialized.
> The problem shows up as odd crashes during connection
> initializtion when we try to access the SCTP address list.
>
> The solution is to refactor how we do registration and
> initialize the lists prior to registering with the protosw.
> Care must be taken since the address list initialization
> depends on some other pieces of SCTP initialization. Also
> the clean-up in case of failure now also needs to be refactored.
>
> Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
> Acked-by: Sridhar Samudrala <sri@us.ibm.com>
Looks good, applied, thanks Vlad.
prev parent reply other threads:[~2008-03-20 22:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 13:30 [PATCH]: [SCTP]: Fix a race between module load and protosw access Vlad Yasevich
2008-03-20 22:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080320.151854.41734345.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=lksctp-developers@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=vladislav.yasevich@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).