netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benoit Boissinot <benoit.boissinot@ens-lyon.org>
To: David Miller <davem@davemloft.net>
Cc: joe@perches.com, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, pekkas@netcore.fi,
	yoshfuji@linux-ipv6.org
Subject: Re: [PATCH] [RFC] [IPv6] spelling fix in /proc: /proc/sys/net/ipv6/conf/default/temp_prefered_lft
Date: Thu, 20 Mar 2008 10:00:11 +0100	[thread overview]
Message-ID: <20080320090011.GK6935@ens-lyon.fr> (raw)
In-Reply-To: <20080319.185649.235399151.davem@davemloft.net>

On Wed, Mar 19, 2008 at 06:56:49PM -0700, David Miller wrote:
> From: Joe Perches <joe@perches.com>
> Date: Wed, 19 Mar 2008 18:25:19 -0700
> 
> > On Wed, 2008-03-19 at 13:52 -0700, David Miller wrote:
> > > From: Benoit Boissinot <benoit.boissinot@ens-lyon.org>
> > > Date: Wed, 19 Mar 2008 21:42:27 +0100
> > > > Here is a patch to fix all the spelling error (prefered -> preferred)
> > > I think this doesn't add any value.
> > > If the procfs file name has to remain the same, which it does,
> > > changing variable and macro names to be different will only
> > > cause merge conflicts and pain yet have no redeeming value.
> > 
> > I disagree.  Proper spelling has value.
> 
> Only if it matches the spelling of thing it is implementing!
> 
> Making the object being implemented and the variables used to do so
> disagree in name will only create other kinds of confusion.

The file already have both occurences, there are function names and
variable with "preferred", sometimes mixed in the same line.

If it can help, the last time a line which uses prefered_lft was
changed, it was more than a year ago (1ab1457c42bc078e5a9becd82a7f9f940b55c53a)
for a whitespace cleanup.
Most of the occurences haven't been touched since the conversion to git.

regards,

Benoit

PS: I don't really care, it's just that I was touching the lifetime code
and tought that maybe I should try to change the whole file before
submitting my code.
-- 
:wq

      reply	other threads:[~2008-03-20  9:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-19 20:42 [PATCH] [RFC] [IPv6] spelling fix in /proc: /proc/sys/net/ipv6/conf/default/temp_prefered_lft Benoit Boissinot
2008-03-19 20:52 ` David Miller
2008-03-19 23:17   ` Rick Jones
2008-03-19 23:53     ` David Miller
2008-03-20  1:25   ` Joe Perches
2008-03-20  1:56     ` David Miller
2008-03-20  9:00       ` Benoit Boissinot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080320090011.GK6935@ens-lyon.fr \
    --to=benoit.boissinot@ens-lyon.org \
    --cc=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pekkas@netcore.fi \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).