From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: paulmck@us.ibm.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6.26] fib_trie: RCU optimizations
Date: Fri, 21 Mar 2008 15:50:48 -0700 (PDT) [thread overview]
Message-ID: <20080321.155048.14913419.davem@davemloft.net> (raw)
In-Reply-To: <20080321075521.49347370@extreme>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri, 21 Mar 2008 07:55:21 -0700
> Small performance improvements.
>
> Eliminate unneeded barrier on deletion. The first pointer to update
> the head of the list is ordered by the second call to rcu_assign_pointer.
> See hlist_add_after_rcu or comparision.
>
> Move rcu_derference to the loop check (like hlist_for_each_rcu), and
> add a prefetch.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Please resubmit without the prefetch unless you can prove
that it noticably improves performance.
It'd be nice to split up these two changes logically anyways
even if the prefetch is warranted, so they can be analyzed
independantly.
prev parent reply other threads:[~2008-03-21 22:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080321075521.49347370@extreme>
2008-03-21 16:01 ` [PATCH net-2.6.26] fib_trie: RCU optimizations Paul E. McKenney
2008-03-21 17:25 ` Eric Dumazet
2008-03-21 17:31 ` Stephen Hemminger
2008-03-21 17:44 ` Eric Dumazet
2008-03-21 22:49 ` David Miller
2008-03-21 22:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080321.155048.14913419.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=paulmck@us.ibm.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).