From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] socket: SOCK_DEBUG type checking
Date: Fri, 21 Mar 2008 17:17:31 -0700 [thread overview]
Message-ID: <20080321171731.2447b435@extreme> (raw)
In-Reply-To: <20080321.155600.121386813.davem@davemloft.net>
On Fri, 21 Mar 2008 15:56:00 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <shemminger@vyatta.com>
> Date: Fri, 21 Mar 2008 07:51:32 -0700
>
> > Use the inline trick (same as pr_debug) to get checking
> > of debug statements even if no code is generated.
> >
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> Applied, and I'll push to net-2.6.26 after some build
> testing.
>
> Although the use of SOCK_DEBUG is so esoteric and sparse,
> I can't see how any of it can be useful for any kind of
> debugging.
>
> I'd say we should just remove this thing.
Agreed, that was the other alternative, just saw it while
looking at filter stuff.
prev parent reply other threads:[~2008-03-22 0:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-21 14:51 [PATCH] socket: SOCK_DEBUG type checking Stephen Hemminger
2008-03-21 22:56 ` David Miller
2008-03-22 0:17 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080321171731.2447b435@extreme \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).