From: David Miller <davem@davemloft.net>
To: paulmck@linux.vnet.ibm.com
Cc: shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: [PATCH] fib_trie: fix warning from rcu_assign_poinger
Date: Sat, 22 Mar 2008 18:02:23 -0700 (PDT) [thread overview]
Message-ID: <20080322.180223.90499780.davem@davemloft.net> (raw)
In-Reply-To: <20080318140654.GA8222@linux.vnet.ibm.com>
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Date: Tue, 18 Mar 2008 07:06:54 -0700
> On Mon, Mar 17, 2008 at 02:27:06PM -0700, Stephen Hemminger wrote:
> > This gets rid of a warning caused by the test in rcu_assign_pointer.
> > I tried to fix rcu_assign_pointer, but that devolved into a long
> > set of discussions about doing it right that came to no real solution.
> > Since the test in rcu_assign_pointer for constant NULL would never succeed in
> > fib_trie, just open code instead.
>
> Indeed -- fooling gcc is nontrivial. :-/
>
> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Applied, thanks everyone.
next prev parent reply other threads:[~2008-03-23 1:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-17 21:02 [PATCH] fib_trie: print information on all routing tables Stephen Hemminger
[not found] ` <20080317142706.235594c9@extreme>
2008-03-18 14:06 ` [PATCH] fib_trie: fix warning from rcu_assign_poinger Paul E. McKenney
2008-03-23 1:02 ` David Miller [this message]
2008-03-24 5:45 ` [PATCH] fib_trie: print information on all routing tables David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080322.180223.90499780.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).