From: Michael Buesch <mb@bu3sch.de>
To: agb@openwrt.org
Cc: Gary Zambrano <zambrano@broadcom.com>, netdev@vger.kernel.org
Subject: [PATCH RFT] b44: Truncate PHY address
Date: Sat, 22 Mar 2008 01:24:20 +0100 [thread overview]
Message-ID: <200803220124.21355.mb@bu3sch.de> (raw)
Some ROMs on embedded devices store incorrect values for
the PHY address of the ethernet device.
It looks like the number is sign-extended.
Truncate the value by applying the PHY-address mask to it.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
---
This patch is untested and needs some testing before it
can go upstream, but I think the chance of introducing bugs
with this is almost zero, as the PHY address register really is
only 5 bits long. So this will do The Right Thing (tm) in any case.
Please report result of the testing back to me. I will also run some
tests later and then submit the patch for inclusion.
Index: wireless-testing/drivers/net/b44.c
===================================================================
--- wireless-testing.orig/drivers/net/b44.c 2008-02-16 19:08:12.000000000 +0100
+++ wireless-testing/drivers/net/b44.c 2008-03-22 01:13:21.000000000 +0100
@@ -2082,6 +2082,11 @@ static int __devinit b44_get_invariants(
addr = sdev->bus->sprom.et0mac;
bp->phy_addr = sdev->bus->sprom.et0phyaddr;
}
+ /* Some ROMs have buggy PHY addresses with the high
+ * bits set (sign extension?). Truncate them to a
+ * valid PHY address. */
+ bp->phy_addr &= 0x1F;
+
memcpy(bp->dev->dev_addr, addr, 6);
if (!is_valid_ether_addr(&bp->dev->dev_addr[0])){
--
Greetings Michael.
reply other threads:[~2008-03-22 0:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803220124.21355.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=agb@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=zambrano@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).