From: David Miller <davem@davemloft.net>
To: den@openvz.org
Cc: yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, kaber@trash.net,
containers@lists.osdl.org, dlezcano@fr.ibm.com,
benjamin.thery@bull.net
Subject: Re: [PATCH 1/3] [IPV6]: Event type in addrconf_ifdown is mis-used.
Date: Sun, 23 Mar 2008 03:17:24 -0700 (PDT) [thread overview]
Message-ID: <20080323.031724.208377895.davem@davemloft.net> (raw)
In-Reply-To: <1206259996.7528.12.camel@iris.sw.ru>
From: "Denis V. Lunev" <den@openvz.org>
Date: Sun, 23 Mar 2008 11:13:16 +0300
> First, this behaviour is broken for a namespace right now in the 2.6.26
> tree. inet6_dev pointer will be NULL for a loopback inside the
> namespace. The case is simple. Just remove all INET6 addresses from a
> loopback device inside a VE. This will call
> inet6_addr_del
> addrconf_ifdown(dev, 1);
> if (dev == init_net.loopback_dev && how == 1)
> how = 0;
> the condition will be false and how will not be changed here.
That's a bug.
You can't mark any namespace's loopback device's inet6_dev as NULL
until you know that all routes, devices, and packets referring to such
devices and routes in that namespace are %100 gone and unreferenced.
It is now obviously apparent that there are several severe errors
here.
next prev parent reply other threads:[~2008-03-23 10:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-18 14:32 [PATCH 0/3] IPv6 start/stop problems Denis V. Lunev
[not found] ` <1205850761.9163.21.camel-aPCOdVxUTlgvJsYlp49lxw@public.gmane.org>
2008-03-18 14:35 ` [PATCH 1/3] [IPV6]: Event type in addrconf_ifdown is mis-used Denis V. Lunev
2008-03-23 0:38 ` David Miller
2008-03-23 8:13 ` Denis V. Lunev
2008-03-23 10:17 ` David Miller [this message]
2008-03-23 14:34 ` Denis V. Lunev
2008-03-24 5:49 ` David Miller
2008-04-03 20:33 ` David Miller
2008-03-18 14:35 ` [PATCH 2/3] [IPV6]: inet6_dev on loopback should be kept until namespace stop Denis V. Lunev
2008-03-18 14:35 ` [PATCH 3/3] [IPV6]: Fix refcounting for anycast dst entries Denis V. Lunev
2008-03-31 8:38 ` [PATCH 0/3] IPv6 start/stop problems Denis V. Lunev
2008-03-31 8:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080323.031724.208377895.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benjamin.thery@bull.net \
--cc=containers@lists.osdl.org \
--cc=den@openvz.org \
--cc=dlezcano@fr.ibm.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).