From: David Miller <davem@davemloft.net>
To: jgarzik@pobox.com
Cc: yang.shi@windriver.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Improvev netconsole support for RTL8139 NIC driver
Date: Tue, 25 Mar 2008 19:42:21 -0700 (PDT) [thread overview]
Message-ID: <20080325.194221.16658596.davem@davemloft.net> (raw)
In-Reply-To: <47E9B39C.5010502@pobox.com>
From: Jeff Garzik <jgarzik@pobox.com>
Date: Tue, 25 Mar 2008 22:23:24 -0400
> This is bogus -- you should never need to slow down the hot path in such
> a way.
Slow down in what way? Even on x86 saving the flags is just
about as expensive as a plain sti/cli.
I would in fact prefer to see drivers unconditionally use
spin_lock_irqsave() et al. in the interrupt handler, for
consistency.
next prev parent reply other threads:[~2008-03-26 2:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 2:12 [PATCH] Improvev netconsole support for RTL8139 NIC driver yshi
2008-03-26 2:23 ` Jeff Garzik
2008-03-26 2:38 ` yshi
2008-03-26 2:42 ` David Miller [this message]
2008-03-26 2:52 ` yshi
2008-03-26 3:14 ` Jeff Garzik
2008-03-26 3:14 ` Jeff Garzik
2008-03-26 3:30 ` David Miller
2008-03-26 3:39 ` Jeff Garzik
2008-03-26 3:48 ` Jeff Garzik
2008-03-26 3:53 ` David Miller
2008-03-26 4:32 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080325.194221.16658596.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yang.shi@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).