From: David Miller <davem@davemloft.net>
To: dlezcano@fr.ibm.com
Cc: xemul@openvz.org, netdev@vger.kernel.org, devel@openvz.org
Subject: Re: [PATCH net-2.6.26][IPV6]: Fix potential net leak and oops in ipv6 routing code.
Date: Wed, 26 Mar 2008 16:50:02 -0700 (PDT) [thread overview]
Message-ID: <20080326.165002.128017657.davem@davemloft.net> (raw)
In-Reply-To: <47EA72E1.804@fr.ibm.com>
From: Daniel Lezcano <dlezcano@fr.ibm.com>
Date: Wed, 26 Mar 2008 16:59:29 +0100
> Pavel Emelyanov wrote:
> > The commits f3db4851 ([NETNS][IPV6] ip6_fib - fib6_clean_all handle several
> > network namespaces) and 69ddb805 ([NETNS][IPV6] route6 - Make proc entry
> > /proc/net/rt6_stats per namespace) made some proc files per net.
> >
> > Both of them introduced potential OOPS - get_proc_net can return NULL, but
> > this check is lost - and a struct net leak - in case single_open() fails the
> > previously got net is not put.
> >
> > Kill all these bugs with one patch.
> >
> > Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
...
> Good catch. Thanks.
>
> Acked-by: Daniel Lezcano <dlezcano@fr.ibm.com>
Applied, thanks everyone!
prev parent reply other threads:[~2008-03-26 23:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 15:55 [PATCH net-2.6.26][IPV6]: Fix potential net leak and oops in ipv6 routing code Pavel Emelyanov
2008-03-26 15:59 ` Daniel Lezcano
2008-03-26 23:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080326.165002.128017657.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=dlezcano@fr.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).