netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jarkao2@gmail.com
Cc: rjw@sisk.pl, a.p.zijlstra@chello.nl, akpm@linux-foundation.org,
	netdev@vger.kernel.org, bugme-daemon@bugzilla.kernel.org,
	marcus@better.se, shemminger@linux-foundation.org,
	linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [Bugme-new] [Bug 10326] New: inconsistent lock state in net_rx_action
Date: Thu, 27 Mar 2008 15:22:18 -0700 (PDT)	[thread overview]
Message-ID: <20080327.152218.235944668.davem@davemloft.net> (raw)
In-Reply-To: <20080327222248.GA3596@ami.dom.local>

From: Jarek Poplawski <jarkao2@gmail.com>
Date: Thu, 27 Mar 2008 23:22:48 +0100

> On Thu, Mar 27, 2008 at 10:56:49PM +0100, Rafael J. Wysocki wrote:
> ...
> > I assume there will be a patch posted for this issue.  Correct?
> 
> I guess Peter should know the answer!

Instead of going back and forth like this can someone post
just take it upon themselves to post such an obvious patch
already :-)

All of this "he'll do it, she'll do it" just wastes time.

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index a2f0032..fae6a7e 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -383,9 +383,11 @@ static inline void __napi_complete(struct napi_struct *n)
 
 static inline void napi_complete(struct napi_struct *n)
 {
-	local_irq_disable();
+	unsigned long flags;
+
+	local_irq_save(flags);
 	__napi_complete(n);
-	local_irq_enable();
+	local_irq_restore(flags);
 }
 
 /**

  reply	other threads:[~2008-03-27 22:22 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-10326-10286@http.bugzilla.kernel.org/>
2008-03-25 20:43 ` [Bugme-new] [Bug 10326] New: inconsistent lock state in net_rx_action Andrew Morton
2008-03-26 23:13   ` Jarek Poplawski
2008-03-27  0:14     ` Andrew Morton
2008-03-27  8:55       ` Jarek Poplawski
2008-03-27  9:08         ` Jarek Poplawski
2008-03-27  9:18         ` Andrew Morton
2008-03-27 10:07           ` Jarek Poplawski
2008-03-27 10:56           ` Peter Zijlstra
2008-03-27 11:03             ` David Miller
2008-03-27 11:59               ` Marcus Better
2008-03-27 12:32                 ` Jarek Poplawski
2008-03-27 21:44                   ` David Miller
2008-03-27 12:22             ` Jarek Poplawski
2008-03-27 12:30               ` Peter Zijlstra
2008-03-27 12:49                 ` Jarek Poplawski
2008-03-27 21:56                   ` Rafael J. Wysocki
2008-03-27 22:22                     ` Jarek Poplawski
2008-03-27 22:22                       ` David Miller [this message]
2008-03-27 22:39                         ` Jarek Poplawski
2008-03-28  0:59                           ` David Miller
2008-03-28 10:12                             ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080327.152218.235944668.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=jarkao2@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcus@better.se \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).