Re: [PATCH] e1000e: test MSI interrupts

[David Miller <davem@davemloft.net>]

From: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Date: Thu, 27 Mar 2008 15:55:34 -0700

> David Miller wrote:
> > From: Jeff Garzik <jeff@garzik.org>
> > Date: Thu, 27 Mar 2008 15:43:42 -0400
> > 
> >> But that seems like a quick id test, with no need for all that
> >> generic MSI test code.
> > 
> > Yes, that is the way to do it.
> 
> I get your point, but this seems a maintainance problem due to not being
> able to "future proof" the solution.  I know what is (IDs) available
> now, but I don't know how many systems in the future IBM will release
> with a similar bridge but a different device ID that causes the same
> issue.  Should we take on the maintenance of continually having to add
> every new bridge device that has this issue to our driver?  Users just
> want this stuff to work when they plug it in.

This is exactly what the PCI quirks list is and it works just fine.

I know the truth is that Intel as a vendor frowns upon putting into
it's driver a list of another vendor's PCI IDs as errata items because
it looks bad.

So just be honest about that.

It is, however, the correct way to address this problem.

> tg3.c has exactly this kind of test and workaround (in fact its where I
> got the code) to work around the same kind of issues.

That is from an era when the situation was much different.

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace