netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Siewior <bigeasy@linutronix.de>
To: uclinux-dev@uclinux.org
Cc: netdev@vger.kernel.org, Jeff Garzik <jgarzik@pobox.com>,
	Greg Ungerer <gerg@uclinux.org>
Subject: [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu driver
Date: Thu, 27 Mar 2008 15:00:41 +0100	[thread overview]
Message-ID: <20080327140041.072611004@linutronix.de> (raw)

I got into this after turning on spinlock debugging.

Jeff: The dev->hard_start_xmit callback is always called from softirq
context so it is save to use spin_lock_irq(), right?

Greg: The isr (fec_enet_rx()) calls three functions. All
but fec_enet_rx() are grabbing the spinlock. Is this on purpose?

Sebastian
-- 


             reply	other threads:[~2008-03-27 14:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-27 14:00 Sebastian Siewior [this message]
2008-03-27 14:00 ` [PATCH / RFC 1/2] fec: kill warnings Sebastian Siewior
2008-03-27 14:00 ` [PATCH / RFC 2/2] fec: fixup spinlocks Sebastian Siewior
2008-03-28  6:58   ` Greg Ungerer
2008-03-28  9:24     ` Sebastian Siewior
2008-03-28 10:24       ` Greg Ungerer
2008-03-28  6:51 ` [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu driver Greg Ungerer
2008-04-02 11:28   ` Sebastian Siewior
2008-04-02 12:50     ` Greg Ungerer
2008-03-29  2:19 ` Jeff Garzik
2008-03-29  2:21 ` Jeff Garzik
2008-04-02 11:11   ` Sebastian Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080327140041.072611004@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=gerg@uclinux.org \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    --cc=uclinux-dev@uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).