From: Olof Johansson <olof@lixom.net>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linuxppc-dev@ozlabs.org, pasemi-linux@ozlabs.org, netdev@vger.kernel.org
Subject: Re: [PATCH 0/2] Two more pasemi_mac patches for 2.6.26
Date: Thu, 27 Mar 2008 14:22:04 -0500 [thread overview]
Message-ID: <20080327192204.GA17881@lixom.net> (raw)
In-Reply-To: <47E9CD2E.7040203@pobox.com>
On Wed, Mar 26, 2008 at 12:12:30AM -0400, Jeff Garzik wrote:
> Olof Johansson wrote:
>> Hi Jeff,
>>
>> The below two patches go on top of the previous patches that were acked
>> by you but applied to pasemi.git for feed up through powerpc.git.
>>
>> One is a couple of fixes for various corner cases in the jumbo support
>> configuration. The second is addition of netpoll support, from Nate
>> Case.
>>
>> Review/ack would be appreciated, I'll feed them up the same path as the
>> other changes.
>
> ACK 1-2, though I would consider closely patch #2, whether you need
> disable_irq() or spin_lock_irqsave() -- which is best for your specific
> driver + platform?
I'm tempted to leave the disable/enable_irq() in there. It's certainly
heavier than doing cpu-side irq masking, but adding a spinlock to the
common interrupt path seems worse to me. I didn't think we considered
the polling to be a hot path anyway...
-Olof
next prev parent reply other threads:[~2008-03-27 19:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 1:56 [PATCH 0/2] Two more pasemi_mac patches for 2.6.26 Olof Johansson
2008-03-26 1:57 ` [PATCH 1/2] pasemi_mac: Jumbo frame bugfixes Olof Johansson
2008-03-26 1:58 ` [PATCH 2/2] pasemi_mac: Netpoll support Olof Johansson
2008-03-26 12:41 ` Valentine Barshak
2008-03-26 15:08 ` Olof Johansson
2008-03-27 22:40 ` [PATCH 2/2 v2] " Olof Johansson
2008-03-29 2:11 ` Jeff Garzik
2008-03-26 4:12 ` [PATCH 0/2] Two more pasemi_mac patches for 2.6.26 Jeff Garzik
2008-03-27 19:22 ` Olof Johansson [this message]
2008-03-27 19:41 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080327192204.GA17881@lixom.net \
--to=olof@lixom.net \
--cc=jgarzik@pobox.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pasemi-linux@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).