netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: rusty@rustcorp.com.au, netdev@vger.kernel.org, jheffner@psc.edu
Subject: Re: [PATCH] Net: Don't send ICMP_FRAG_NEEDED for GSO packets
Date: Fri, 28 Mar 2008 16:24:12 -0700 (PDT)	[thread overview]
Message-ID: <20080328.162412.50278632.davem@davemloft.net> (raw)
In-Reply-To: <20080328084043.GA22513@gondor.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 28 Mar 2008 16:40:43 +0800

> On Fri, Mar 28, 2008 at 07:34:08PM +1100, Rusty Russell wrote:
> > Commit 9af3912ec9e30509b76cb376abb65a4d8af27df3 added a new check to
> > send ICMP fragmentation needed for large packets.
> > 
> > Unlike the check in ip_finish_output(), it doesn't check for GSO.  I
> > triggered this with the GSO TUN patches, so not sure if it needs to be
> > in 2.6.25 or not (do we otherwise forward GSO packets?).
> > 
> > Cc: John Heffner <jheffner@psc.edu>
> > Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> 
> Since this is a regression for Xen, I would say yes.

Applied.

But Rusty, when referencing commits, always provide a
text string of the commit's header line because in
different trees and backports the commit ID may
change.

I fixed it up this time...

Thanks.

      reply	other threads:[~2008-03-28 23:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-28  8:34 [PATCH] Net: Don't send ICMP_FRAG_NEEDED for GSO packets Rusty Russell
2008-03-28  8:40 ` Herbert Xu
2008-03-28 23:24   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080328.162412.50278632.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=jheffner@psc.edu \
    --cc=netdev@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).