* [PATCH] SCTP: Remove an useless parameter from
@ 2008-03-28 1:52 Gui Jianfeng
2008-03-28 2:07 ` Arnaldo Carvalho de Melo
2008-03-28 13:36 ` Vlad Yasevich
0 siblings, 2 replies; 6+ messages in thread
From: Gui Jianfeng @ 2008-03-28 1:52 UTC (permalink / raw)
To: vladislav; +Cc: netdev, lksctp-dev, David Miller
Vlad,
There is an useless parameter in sctp_cmd_hb_timer_update,
remove it.
Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
---
net/sctp/sm_sideeffect.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
index 28eb38e..5daeab5 100644
--- a/net/sctp/sm_sideeffect.c
+++ b/net/sctp/sm_sideeffect.c
@@ -593,7 +593,6 @@ static void sctp_cmd_t3_rtx_timers_stop(sctp_cmd_seq_t *cmds,
/* Helper function to update the heartbeat timer. */
static void sctp_cmd_hb_timer_update(sctp_cmd_seq_t *cmds,
- struct sctp_association *asoc,
struct sctp_transport *t)
{
/* Update the heartbeat timer. */
@@ -1457,7 +1456,7 @@ static int sctp_cmd_interpreter(sctp_event_t event_type,
case SCTP_CMD_HB_TIMER_UPDATE:
t = cmd->obj.transport;
- sctp_cmd_hb_timer_update(commands, asoc, t);
+ sctp_cmd_hb_timer_update(commands, t);
break;
case SCTP_CMD_HB_TIMERS_STOP:
--
1.5.3
--
Regards
Gui Jianfeng
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] SCTP: Remove an useless parameter from
2008-03-28 1:52 [PATCH] SCTP: Remove an useless parameter from Gui Jianfeng
@ 2008-03-28 2:07 ` Arnaldo Carvalho de Melo
2008-03-28 2:25 ` Gui Jianfeng
2008-03-28 2:47 ` Wang Chen
2008-03-28 13:36 ` Vlad Yasevich
1 sibling, 2 replies; 6+ messages in thread
From: Arnaldo Carvalho de Melo @ 2008-03-28 2:07 UTC (permalink / raw)
To: Gui Jianfeng; +Cc: vladislav, netdev, lksctp-dev, David Miller
Em Fri, Mar 28, 2008 at 09:52:22AM +0800, Gui Jianfeng escreveu:
> Vlad,
> There is an useless parameter in sctp_cmd_hb_timer_update,
> remove it.
>
> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
> ---
> net/sctp/sm_sideeffect.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
> index 28eb38e..5daeab5 100644
> --- a/net/sctp/sm_sideeffect.c
> +++ b/net/sctp/sm_sideeffect.c
> @@ -593,7 +593,6 @@ static void sctp_cmd_t3_rtx_timers_stop(sctp_cmd_seq_t *cmds,
>
> /* Helper function to update the heartbeat timer. */
> static void sctp_cmd_hb_timer_update(sctp_cmd_seq_t *cmds,
> - struct sctp_association *asoc,
> struct sctp_transport *t)
> {
> /* Update the heartbeat timer. */
> @@ -1457,7 +1456,7 @@ static int sctp_cmd_interpreter(sctp_event_t event_type,
>
> case SCTP_CMD_HB_TIMER_UPDATE:
> t = cmd->obj.transport;
> - sctp_cmd_hb_timer_update(commands, asoc, t);
> + sctp_cmd_hb_timer_update(commands, t);
> break;
you mean it was not compiling before?
- Arnaldo
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] SCTP: Remove an useless parameter from
2008-03-28 2:07 ` Arnaldo Carvalho de Melo
@ 2008-03-28 2:25 ` Gui Jianfeng
2008-03-28 2:54 ` Arnaldo Carvalho de Melo
2008-03-28 2:47 ` Wang Chen
1 sibling, 1 reply; 6+ messages in thread
From: Gui Jianfeng @ 2008-03-28 2:25 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Gui Jianfeng, vladislav, netdev,
lksctp-dev <lksctp-deve
Arnaldo Carvalho de Melo wrote:
> Em Fri, Mar 28, 2008 at 09:52:22AM +0800, Gui Jianfeng escreveu:
>> Vlad,
>> There is an useless parameter in sctp_cmd_hb_timer_update,
>> remove it.
>>
>> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
>> ---
>> net/sctp/sm_sideeffect.c | 3 +--
>> 1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
>> index 28eb38e..5daeab5 100644
>> --- a/net/sctp/sm_sideeffect.c
>> +++ b/net/sctp/sm_sideeffect.c
>> @@ -593,7 +593,6 @@ static void sctp_cmd_t3_rtx_timers_stop(sctp_cmd_seq_t *cmds,
>>
>> /* Helper function to update the heartbeat timer. */
>> static void sctp_cmd_hb_timer_update(sctp_cmd_seq_t *cmds,
>> - struct sctp_association *asoc,
>> struct sctp_transport *t)
>> {
>> /* Update the heartbeat timer. */
>> @@ -1457,7 +1456,7 @@ static int sctp_cmd_interpreter(sctp_event_t event_type,
>>
>> case SCTP_CMD_HB_TIMER_UPDATE:
>> t = cmd->obj.transport;
>> - sctp_cmd_hb_timer_update(commands, asoc, t);
>> + sctp_cmd_hb_timer_update(commands, t);
>> break;
>
> you mean it was not compiling before?
I mean this parameter is never used in this function.
>
> - Arnaldo
>
>
>
--
Regards
Gui Jianfeng
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] SCTP: Remove an useless parameter from
2008-03-28 2:25 ` Gui Jianfeng
@ 2008-03-28 2:54 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 6+ messages in thread
From: Arnaldo Carvalho de Melo @ 2008-03-28 2:54 UTC (permalink / raw)
To: Gui Jianfeng
Cc: Arnaldo Carvalho de Melo, vladislav, netdev, lksctp-dev,
David Miller
Em Fri, Mar 28, 2008 at 10:25:18AM +0800, Gui Jianfeng escreveu:
> Arnaldo Carvalho de Melo wrote:
> > Em Fri, Mar 28, 2008 at 09:52:22AM +0800, Gui Jianfeng escreveu:
> >> Vlad,
> >> There is an useless parameter in sctp_cmd_hb_timer_update,
> >> remove it.
> >>
> >> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
> >> ---
> >> net/sctp/sm_sideeffect.c | 3 +--
> >> 1 files changed, 1 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
> >> index 28eb38e..5daeab5 100644
> >> --- a/net/sctp/sm_sideeffect.c
> >> +++ b/net/sctp/sm_sideeffect.c
> >> @@ -593,7 +593,6 @@ static void sctp_cmd_t3_rtx_timers_stop(sctp_cmd_seq_t *cmds,
> >>
> >> /* Helper function to update the heartbeat timer. */
> >> static void sctp_cmd_hb_timer_update(sctp_cmd_seq_t *cmds,
> >> - struct sctp_association *asoc,
> >> struct sctp_transport *t)
> >> {
> >> /* Update the heartbeat timer. */
> >> @@ -1457,7 +1456,7 @@ static int sctp_cmd_interpreter(sctp_event_t event_type,
> >>
> >> case SCTP_CMD_HB_TIMER_UPDATE:
> >> t = cmd->obj.transport;
> >> - sctp_cmd_hb_timer_update(commands, asoc, t);
> >> + sctp_cmd_hb_timer_update(commands, t);
> >> break;
> >
> > you mean it was not compiling before?
>
> I mean this parameter is never used in this function.
Sorry for the disturbance, you're of course right.
- Arnaldo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] SCTP: Remove an useless parameter from
2008-03-28 2:07 ` Arnaldo Carvalho de Melo
2008-03-28 2:25 ` Gui Jianfeng
@ 2008-03-28 2:47 ` Wang Chen
1 sibling, 0 replies; 6+ messages in thread
From: Wang Chen @ 2008-03-28 2:47 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Gui Jianfeng, vladislav, netdev,
lksctp-dev <lksctp-deve
Arnaldo Carvalho de Melo said the following on 2008-3-28 10:07:
> Em Fri, Mar 28, 2008 at 09:52:22AM +0800, Gui Jianfeng escreveu:
>> Vlad,
>> There is an useless parameter in sctp_cmd_hb_timer_update,
>> remove it.
>>
>> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
>> ---
>> net/sctp/sm_sideeffect.c | 3 +--
>> 1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
>> index 28eb38e..5daeab5 100644
>> --- a/net/sctp/sm_sideeffect.c
>> +++ b/net/sctp/sm_sideeffect.c
>> @@ -593,7 +593,6 @@ static void sctp_cmd_t3_rtx_timers_stop(sctp_cmd_seq_t *cmds,
>>
>> /* Helper function to update the heartbeat timer. */
>> static void sctp_cmd_hb_timer_update(sctp_cmd_seq_t *cmds,
>> - struct sctp_association *asoc,
>> struct sctp_transport *t)
>> {
>> /* Update the heartbeat timer. */
>> @@ -1457,7 +1456,7 @@ static int sctp_cmd_interpreter(sctp_event_t event_type,
>>
>> case SCTP_CMD_HB_TIMER_UPDATE:
>> t = cmd->obj.transport;
>> - sctp_cmd_hb_timer_update(commands, asoc, t);
>> + sctp_cmd_hb_timer_update(commands, t);
>> break;
>
> you mean it was not compiling before?
>
Compiler can not find whether a parameter of function is used.
--
WCN
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] SCTP: Remove an useless parameter from
2008-03-28 1:52 [PATCH] SCTP: Remove an useless parameter from Gui Jianfeng
2008-03-28 2:07 ` Arnaldo Carvalho de Melo
@ 2008-03-28 13:36 ` Vlad Yasevich
1 sibling, 0 replies; 6+ messages in thread
From: Vlad Yasevich @ 2008-03-28 13:36 UTC (permalink / raw)
To: Gui Jianfeng; +Cc: netdev, lksctp-dev, David Miller
Gui Jianfeng wrote:
> Vlad,
> There is an useless parameter in sctp_cmd_hb_timer_update,
> remove it.
>
> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Applied, thanks. Will push to David shortly.
-vlad
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-03-28 13:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-28 1:52 [PATCH] SCTP: Remove an useless parameter from Gui Jianfeng
2008-03-28 2:07 ` Arnaldo Carvalho de Melo
2008-03-28 2:25 ` Gui Jianfeng
2008-03-28 2:54 ` Arnaldo Carvalho de Melo
2008-03-28 2:47 ` Wang Chen
2008-03-28 13:36 ` Vlad Yasevich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).