From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnaldo Carvalho de Melo Subject: Re: [PATCH 3/11 net-2.6.26] [DCCP]: dccp_v(4|6)_ctl_socket is leaked. Date: Fri, 28 Mar 2008 11:44:46 -0300 Message-ID: <20080328144446.GU14945@ghostprotocols.net> References: <1206695071.3271.8.camel@iris.sw.ru> <1206695338-5947-3-git-send-email-den@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org To: "Denis V. Lunev" Return-path: Content-Disposition: inline In-Reply-To: <1206695338-5947-3-git-send-email-den-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: netdev.vger.kernel.org Em Fri, Mar 28, 2008 at 12:08:50PM +0300, Denis V. Lunev escreveu: > This seems a purism as module can't be unloaded, but though if cleanup method > is present it should be correct and clean all staff created. Its the right thing to do :-) But perhaps we could have a inet_csk_ctl_sock_destroy() as we have inet_csk_ctl_sock_create? And since this is not csk at all, could you please rename it to inet_ctl_sock_{create,destroy}()? I Agree with Vlad and Pavel that this would make it more clear, as SCTP is not (yet) a inet_connection_sock. - Arnaldo