From: Andrew Morton <akpm@linux-foundation.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: jeff@garzik.org, netdev@vger.kernel.org, jkschind@gmail.com
Subject: Re: [patch 02/21] drivers/net/3c501.c: replace init_module&cleanup_module with module_init&module_exit
Date: Fri, 28 Mar 2008 15:07:10 -0700 [thread overview]
Message-ID: <20080328150710.6a664440.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080328214755.GE10722@ZenIV.linux.org.uk>
On Fri, 28 Mar 2008 21:47:55 +0000
Al Viro <viro@ZenIV.linux.org.uk> wrote:
> On Fri, Mar 28, 2008 at 02:41:16PM -0700, akpm@linux-foundation.org wrote:
>
> > Replace init_module and cleanup_module with static functions and
> > module_init/module_exit.
>
> Would the esteemed sir bother to build the resulting tree with drivers
> in question non-modular?
>
> Damnit, people, try to think for a minute. If these functions were
> not called directly in non-modular case, the driver would not work
> built-in. Which is not apriori impossible, but might warrant some
> further investigation. Use of grep, for starters...
>
well... The probe functions are still called, only they're now called at
initcall-time as well as from the infamous Space.c.
So I guess these patches should at least have removed the calls from
Space.c tables, but iirc things aren't as simple as that. I don't remember
why.
> IOW, please unapply the patches in question.
always happy to do that.
next prev parent reply other threads:[~2008-03-28 22:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 21:41 [patch 02/21] drivers/net/3c501.c: replace init_module&cleanup_module with module_init&module_exit akpm
2008-03-28 21:47 ` Al Viro
2008-03-28 21:58 ` Al Viro
2008-03-28 22:07 ` Andrew Morton [this message]
2008-03-28 22:23 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080328150710.6a664440.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=jkschind@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).