From: Rusty Russell <rusty@rustcorp.com.au>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>,
John Heffner <jheffner@psc.edu>
Subject: [PATCH] Net: Don't send ICMP_FRAG_NEEDED for GSO packets
Date: Fri, 28 Mar 2008 19:34:08 +1100 [thread overview]
Message-ID: <200803281934.09308.rusty@rustcorp.com.au> (raw)
Commit 9af3912ec9e30509b76cb376abb65a4d8af27df3 added a new check to
send ICMP fragmentation needed for large packets.
Unlike the check in ip_finish_output(), it doesn't check for GSO. I
triggered this with the GSO TUN patches, so not sure if it needs to be
in 2.6.25 or not (do we otherwise forward GSO packets?).
Cc: John Heffner <jheffner@psc.edu>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
diff -r 69b8317ff51c net/ipv4/ip_forward.c
--- a/net/ipv4/ip_forward.c Fri Mar 28 14:04:48 2008 +1100
+++ b/net/ipv4/ip_forward.c Fri Mar 28 19:18:15 2008 +1100
@@ -85,7 +85,7 @@ int ip_forward(struct sk_buff *skb)
if (opt->is_strictroute && rt->rt_dst != rt->rt_gateway)
goto sr_failed;
- if (unlikely(skb->len > dst_mtu(&rt->u.dst) &&
+ if (unlikely(skb->len > dst_mtu(&rt->u.dst) && !skb_is_gso(skb) &&
(ip_hdr(skb)->frag_off & htons(IP_DF))) && !skb->local_df) {
IP_INC_STATS(IPSTATS_MIB_FRAGFAILS);
icmp_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED,
next reply other threads:[~2008-03-28 8:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 8:34 Rusty Russell [this message]
2008-03-28 8:40 ` [PATCH] Net: Don't send ICMP_FRAG_NEEDED for GSO packets Herbert Xu
2008-03-28 23:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803281934.09308.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jheffner@psc.edu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).