[patch 2/4] drivers/net/bonding/bond_sysfs.c: suppress uninitialized var warning

[patch 2/4] drivers/net/bonding/bond_sysfs.c: suppress uninitialized var warning

[akpm]

From: Andrew Morton <akpm@linux-foundation.org>

drivers/net/bonding/bond_sysfs.c: In function `bonding_store_slaves':
drivers/net/bonding/bond_sysfs.c:250: warning: 'original_mtu' might be used uninitialized in this function

Cc: Jay Vosburgh <fubar@us.ibm.com>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/net/bonding/bond_sysfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/net/bonding/bond_sysfs.c~drivers-net-bonding-bond_sysfsc-suppress-uninitialized-var-warning drivers/net/bonding/bond_sysfs.c
--- a/drivers/net/bonding/bond_sysfs.c~drivers-net-bonding-bond_sysfsc-suppress-uninitialized-var-warning
+++ a/drivers/net/bonding/bond_sysfs.c
@@ -247,7 +247,7 @@ static ssize_t bonding_store_slaves(stru
 	char command[IFNAMSIZ + 1] = { 0, };
 	char *ifname;
 	int i, res, found, ret = count;
-	u32 original_mtu;
+	u32 uninitialized_var(original_mtu);
 	struct slave *slave;
 	struct net_device *dev = NULL;
 	struct bonding *bond = to_bond(d);
_

Re: [patch 2/4] drivers/net/bonding/bond_sysfs.c: suppress uninitialized var warning

[David Miller]

From: akpm@linux-foundation.org
Date: Fri, 28 Mar 2008 14:37:30 -0700

> From: Andrew Morton <akpm@linux-foundation.org>
> 
> drivers/net/bonding/bond_sysfs.c: In function `bonding_store_slaves':
> drivers/net/bonding/bond_sysfs.c:250: warning: 'original_mtu' might be used uninitialized in this function
> 
> Cc: Jay Vosburgh <fubar@us.ibm.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Barf!

I'll fix it like this:

commit 6952d8923bcc8d6b8b43b065cfe9a31bb24f0d58
Author: David S. Miller <davem@davemloft.net>
Date:   Fri Mar 28 16:15:38 2008 -0700

    [BOND]: Fix warning in bond_sysfs.c
    
    original_mtu is only used if we end up with a non-NULL
    dev, and it is assigned in all such cases, but GCC can't
    see that.
    
    Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c
index 90a1f31..979c2d0 100644
--- a/drivers/net/bonding/bond_sysfs.c
+++ b/drivers/net/bonding/bond_sysfs.c
@@ -341,6 +341,7 @@ static ssize_t bonding_store_slaves(struct device *d,
 
 	if (command[0] == '-') {
 		dev = NULL;
+		original_mtu = 0;
 		bond_for_each_slave(bond, slave, i)
 			if (strnicmp(slave->dev->name, ifname, IFNAMSIZ) == 0) {
 				dev = slave->dev;