* Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24 [not found] ` <47ECCD17.7080908@artcom.pl> @ 2008-03-28 17:46 ` Andrew Morton 2008-03-28 21:57 ` Rafael J. Wysocki 0 siblings, 1 reply; 2+ messages in thread From: Andrew Morton @ 2008-03-28 17:46 UTC (permalink / raw) To: Paweł Staszewski Cc: Linus Torvalds, Christoph Lameter, Rafael J. Wysocki, LKML, Adrian Bunk, Natalie Protasevich, netdev On Fri, 28 Mar 2008 11:48:55 +0100 Pawe__ Staszewski <pstaszewski@artcom.pl> wrote: > Linus Torvalds pisze: > > On Thu, 27 Mar 2008, Christoph Lameter wrote: > > > >> Slab allocations can never use GFP_HIGHMEM. > >> > > > > Totally irrelevant. > > > > The page allocation path does > > > > if (gfp_flags & __GFP_ZERO) > > prep_zero_page(page, order, gfp_flags); > > > > and that will cause a warning REGARDLESS of whether the page is a HIGHMEM > > page or not. > > > > And the fact is, passing in GFP_ZERO from the SLUB code is a bug > > regardless, because it unnecessarily does the dual memset(). > > > > So here's a damn big clue: > > - SLUB does its own GFP_ZERO handling > > - so passing GFP_ZERO down to the page allocator is a f*cking bug > > - and this has NOTHING what-so-ever to do with GFP_HIGHMEM or even > > whether the warning is "valid" or not - it's a bug even if the warning > > had never happened. > > > > So stop blathering, and just admit that this was buggy. It was also > > fundamentally fragile to leave GFP_ZERO around when it was known to not be > > valid at that point (exactly because GFP_ZERO was handled by the caller). > > > > Linus > > > > > > > Sorry for offtopic but i have the same problem with kernels 2.6.25-* > like: > http://kerneltrap.org/mailarchive/linux-netdev/2008/3/27/1274804 > http://kerneltrap.org/mailarchive/linux-netdev/2008/3/27/1270334 > > I search linux-netdev and found this links. > I only sugest that > > Denys Fedoryshchenko > > can have the same problem that i have with this kernels. > I must revert my all kernels to 2.6.23.11 to get stable work on high (ip > traffic) loads. > > And there is no documentation for LRO... and Stephen Hemminger write me > that LRO is not compatible with bridgeing and routing. > see this link: > http://bugzilla.kernel.org/show_bug.cgi?id=10335 > > > So there must be some documentation for this ... because people can have > many problems with this. > These are all networking things, so let's cc that list. > > Sorry for offtopic but this can resolve problems like my and Denys . It's very on-topic - thanks for the reminder. Rafael, are these things actually on the list? ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24 2008-03-28 17:46 ` 2.6.25-rc7-git2: Reported regressions from 2.6.24 Andrew Morton @ 2008-03-28 21:57 ` Rafael J. Wysocki 0 siblings, 0 replies; 2+ messages in thread From: Rafael J. Wysocki @ 2008-03-28 21:57 UTC (permalink / raw) To: Andrew Morton Cc: Paweł Staszewski, Linus Torvalds, Christoph Lameter, LKML, Adrian Bunk, Natalie Protasevich, netdev On Friday, 28 of March 2008, Andrew Morton wrote: > On Fri, 28 Mar 2008 11:48:55 +0100 Pawe__ Staszewski <pstaszewski@artcom.pl> wrote: > > > Linus Torvalds pisze: > > > On Thu, 27 Mar 2008, Christoph Lameter wrote: > > > > > >> Slab allocations can never use GFP_HIGHMEM. > > >> > > > > > > Totally irrelevant. > > > > > > The page allocation path does > > > > > > if (gfp_flags & __GFP_ZERO) > > > prep_zero_page(page, order, gfp_flags); > > > > > > and that will cause a warning REGARDLESS of whether the page is a HIGHMEM > > > page or not. > > > > > > And the fact is, passing in GFP_ZERO from the SLUB code is a bug > > > regardless, because it unnecessarily does the dual memset(). > > > > > > So here's a damn big clue: > > > - SLUB does its own GFP_ZERO handling > > > - so passing GFP_ZERO down to the page allocator is a f*cking bug > > > - and this has NOTHING what-so-ever to do with GFP_HIGHMEM or even > > > whether the warning is "valid" or not - it's a bug even if the warning > > > had never happened. > > > > > > So stop blathering, and just admit that this was buggy. It was also > > > fundamentally fragile to leave GFP_ZERO around when it was known to not be > > > valid at that point (exactly because GFP_ZERO was handled by the caller). > > > > > > Linus > > > > > > > > > > > Sorry for offtopic but i have the same problem with kernels 2.6.25-* > > like: > > http://kerneltrap.org/mailarchive/linux-netdev/2008/3/27/1274804 > > http://kerneltrap.org/mailarchive/linux-netdev/2008/3/27/1270334 > > > > I search linux-netdev and found this links. > > I only sugest that > > > > Denys Fedoryshchenko > > > > can have the same problem that i have with this kernels. > > I must revert my all kernels to 2.6.23.11 to get stable work on high (ip > > traffic) loads. > > > > And there is no documentation for LRO... and Stephen Hemminger write me > > that LRO is not compatible with bridgeing and routing. > > see this link: > > http://bugzilla.kernel.org/show_bug.cgi?id=10335 > > > > > > So there must be some documentation for this ... because people can have > > many problems with this. > > > > These are all networking things, so let's cc that list. > > > > > Sorry for offtopic but this can resolve problems like my and Denys . > > It's very on-topic - thanks for the reminder. > > Rafael, are these things actually on the list? Well, this isn't a recent regression, at least not from 2.6.24, so I don't list it. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-28 21:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200803272353.51901.rjw@sisk.pl>
[not found] ` <alpine.LFD.1.00.0803271859280.14670@woody.linux-foundation.org>
[not found] ` <Pine.LNX.4.64.0803272002090.11979@schroedinger.engr.sgi.com>
[not found] ` <alpine.LFD.1.00.0803272050290.14670@woody.linux-foundation.org>
[not found] ` <47ECCD17.7080908@artcom.pl>
2008-03-28 17:46 ` 2.6.25-rc7-git2: Reported regressions from 2.6.24 Andrew Morton
2008-03-28 21:57 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).