From: Greg KH <greg@kroah.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, Andy Whitcroft <apw@shadowen.org>,
Christopher Harrer <charrer@alacritech.com>,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Subject: Re: [BUILD_FAILURE] linux-next: Tree for March 31 build fails with CONFIG_SLICOSS=y
Date: Mon, 31 Mar 2008 08:55:54 -0700 [thread overview]
Message-ID: <20080331155554.GE3696@kroah.com> (raw)
In-Reply-To: <20080401003110.d4834b07.sfr@canb.auug.org.au>
On Tue, Apr 01, 2008 at 12:31:10AM +1100, Stephen Rothwell wrote:
> Hi Greg,
>
> Strike two! Again, these drivers need to build (or not try to build) for
> all architectures ... Its out until you tell me the above is true.
>
> #if defined(CONFIG_X86_64)
> hcmd->cmdsize = (ulong32) ((((ulong64) & ihcmd->u.slic_buffers.bufs[1] -
> (ulong64) hcmd) + 31) >> 5);
> #elif defined(CONFIG_X86)
> hcmd->cmdsize = ((((ulong32) & ihcmd->u.slic_buffers.bufs[1] -
> (ulong32) hcmd) + 31) >> 5);
> #else
> Stop Compilation;
Ah, missed that one, that's why it built on my machines (x86-64 and
i386), but would die on anything else. That test is just wrong, I'll
fix it up to get it to build on all arches (doesn't mean it will run
though, it assumes that port io is memory mapped flat on all machines
and still needs a lot of work to be fixed.
thanks,
greg k-h
prev parent reply other threads:[~2008-03-31 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080331181118.7964d4a9.sfr@canb.auug.org.au>
2008-03-31 13:17 ` [BUILD_FAILURE] linux-next: Tree for March 31 build fails with CONFIG_SLICOSS=y Kamalesh Babulal
2008-03-31 13:31 ` Stephen Rothwell
2008-03-31 15:55 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080331155554.GE3696@kroah.com \
--to=greg@kroah.com \
--cc=apw@shadowen.org \
--cc=charrer@alacritech.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).