From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, chas@cmf.nrl.navy.mil, jeff@garzik.org
Subject: Re: [patch 1/4] drivers/atm/firestream.c: suppress uninitialized var warning
Date: Mon, 31 Mar 2008 16:57:32 +0100 [thread overview]
Message-ID: <20080331155732.GK9785@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20080328173946.23903be0.akpm@linux-foundation.org>
On Fri, Mar 28, 2008 at 05:39:46PM -0700, Andrew Morton wrote:
> On Fri, 28 Mar 2008 17:35:23 -0700 (PDT) David Miller <davem@davemloft.net> wrote:
>
> > From: Andrew Morton <akpm@linux-foundation.org>
> > Date: Fri, 28 Mar 2008 17:11:28 -0700
> >
> > > Plus uninitialized_var() gives us something to grep for and
> > > experiment with if/when future gcc's get smarter.
> >
> > That's sounds like a great investment of your time.
> >
> > I guess there aren't any more interesting things to work
> > on, nor bugs to fix.
>
> So you're all outa reasons.
Not really... "we know better, gcc must STFU" applies _now_. And gcc getting
smarter is not the only way it can become false - code change in the function
can create real uninitialized use. gcc tends to change the warning on that,
but not if it's told to STFU in either way.
IOW, my preference would be to leave the warning as is.
prev parent reply other threads:[~2008-03-31 15:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 21:37 [patch 1/4] drivers/atm/firestream.c: suppress uninitialized var warning akpm
2008-03-28 23:20 ` David Miller
2008-03-28 23:54 ` Andrew Morton
2008-03-28 23:58 ` David Miller
2008-03-29 0:11 ` Andrew Morton
2008-03-29 0:35 ` David Miller
2008-03-29 0:39 ` Andrew Morton
2008-03-31 15:57 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080331155732.GK9785@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=chas@cmf.nrl.navy.mil \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).