netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: frank.blaschka@de.ibm.com
To: jgarzik@pobox.com
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org,
	Ursula Braun <braunu@de.ibm.com>
Subject: [patch 4/8] qeth: CCL-sequence numbers required for protocol ETH_P_802_2 only
Date: Tue, 01 Apr 2008 10:26:56 +0200	[thread overview]
Message-ID: <20080401082742.852685000@de.ibm.com> (raw)
In-Reply-To: 20080401082652.754871000@de.ibm.com

[-- Attachment #1: 04-qeth_ccl_sequence.patch --]
[-- Type: text/plain, Size: 1151 bytes --]

From: Ursula Braun <braunu@de.ibm.com>

Symptom:     slow CCL response time
Problem:     non-ETH_P_802_2 packets are not delivered to NDH for
             CCL. But CCL detects missing sequence numbers, which
             cause a serious performance problem with CCL.
Solution:    assign sequence numbers only to 802.2 packets.

Signed-off-by: Ursula Braun <braunu@de.ibm.com>
Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
---
 drivers/s390/net/qeth_l2_main.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: git_davem-2.6.26/drivers/s390/net/qeth_l2_main.c
===================================================================
--- git_davem-2.6.26.orig/drivers/s390/net/qeth_l2_main.c	2008-03-26 09:21:08.000000000 +0100
+++ git_davem-2.6.26/drivers/s390/net/qeth_l2_main.c	2008-03-31 11:19:36.000000000 +0200
@@ -451,7 +451,8 @@
 				skb->ip_summed = CHECKSUM_UNNECESSARY;
 			else
 				skb->ip_summed = CHECKSUM_NONE;
-			*((__u32 *)skb->cb) = ++card->seqno.pkt_seqno;
+			if (skb->protocol == htons(ETH_P_802_2))
+				*((__u32 *)skb->cb) = ++card->seqno.pkt_seqno;
 			len = skb->len;
 			netif_rx(skb);
 			break;

-- 

  parent reply	other threads:[~2008-04-01  8:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-01  8:26 [patch 0/8] s390: qeth bug fixes for 2.6.26 frank.blaschka
2008-04-01  8:26 ` [patch 1/8] qeth: improve ip_list administration after deregister failures frank.blaschka
2008-04-12  9:02   ` Jeff Garzik
2008-04-01  8:26 ` [patch 2/8] qeth: allow qdio queue element addresses > 2GB frank.blaschka
2008-04-01  8:26 ` [patch 3/8] qeth: set lan_online flag after a received STARTLAN frank.blaschka
2008-04-01  8:26 ` frank.blaschka [this message]
2008-04-01  8:26 ` [patch 6/8] qeth: improving debug message handling frank.blaschka
2008-04-01  8:26 ` [patch 7/8] qeth: core code should alloc headroom for LLC protocol frank.blaschka
2008-04-01  8:27 ` [patch 8/8] qeth: keep ip-address after LAN_OFFLINE failure frank.blaschka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080401082742.852685000@de.ibm.com \
    --to=frank.blaschka@de.ibm.com \
    --cc=braunu@de.ibm.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).