From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: GFP_ATOMIC page allocation failures.
Date: Wed, 02 Apr 2008 01:24:06 -0700 (PDT)
Message-ID: <20080402.012406.246863209.davem@davemloft.net>
References: <47F32789.2070703@redhat.com>
	<20080402005646.f8df1c1b.akpm@linux-foundation.org>
	<20080402171104.9591.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: akpm@linux-foundation.org, csnook@redhat.com,
	davej@codemonkey.org.uk, nickpiggin@yahoo.com.au,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
To: kosaki.motohiro@jp.fujitsu.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:47336
	"EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK)
	by vger.kernel.org with ESMTP id S1752394AbYDBIYG (ORCPT
	<rfc822;netdev@vger.kernel.org>); Wed, 2 Apr 2008 04:24:06 -0400
In-Reply-To: <20080402171104.9591.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Date: Wed, 02 Apr 2008 17:17:50 +0900

> if network guys hope known-good driver should call 
> __netdev_alloc_skb(dev, length, GFP_ATOMIC|__GFP_NOWARN) instead netdev_alloc_skb,
> I think we should make netdev_alloc_skb_nowarn.

Giving it a proper name like this takes away the indication that this
situation is very special.

Two leading underscores to an interface means "something special and
unusual requiring more careful consideration than usual is occuring
here."  netdev_alloc_skb_nowarn() on the other hand, does not
convey this meaning.

And we will have very few drivers that use this construct, thus it
really is best to handle things the way Andrew has.