From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: GFP_ATOMIC page allocation failures. Date: Wed, 2 Apr 2008 01:43:17 -0700 Message-ID: <20080402014317.7634515f.akpm@linux-foundation.org> References: <47F32789.2070703@redhat.com> <20080402005646.f8df1c1b.akpm@linux-foundation.org> <20080402171104.9591.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20080402.012406.246863209.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: kosaki.motohiro@jp.fujitsu.com, csnook@redhat.com, davej@codemonkey.org.uk, nickpiggin@yahoo.com.au, linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: David Miller Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:57165 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752314AbYDBIo0 (ORCPT ); Wed, 2 Apr 2008 04:44:26 -0400 In-Reply-To: <20080402.012406.246863209.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 02 Apr 2008 01:24:06 -0700 (PDT) David Miller wrote: > From: KOSAKI Motohiro > Date: Wed, 02 Apr 2008 17:17:50 +0900 > > > if network guys hope known-good driver should call > > __netdev_alloc_skb(dev, length, GFP_ATOMIC|__GFP_NOWARN) instead netdev_alloc_skb, > > I think we should make netdev_alloc_skb_nowarn. > > Giving it a proper name like this takes away the indication that this > situation is very special. > > Two leading underscores to an interface means "something special and > unusual requiring more careful consideration than usual is occuring > here." netdev_alloc_skb_nowarn() on the other hand, does not > convey this meaning. > > And we will have very few drivers that use this construct, thus it > really is best to handle things the way Andrew has. Oh. I just went and redid thing the other way. Picked the same name too. Whatever.