From: Stephen Hemminger <shemminger@vyatta.com>
To: Stephen Hemminger <shemminger@vyatta.com>,
Jeff Garzik <jgarzik@pobox.com>,
Cesar Eduardo Barros <cesarb@cesarb.net>
Cc: netdev@vger.kernel.org, tom@sharkbay.at
Subject: [PATCH 3/3] sc92031: use netdev_alloc_skb
Date: Wed, 2 Apr 2008 10:13:12 -0700 [thread overview]
Message-ID: <20080402101312.0db8f52e@extreme> (raw)
In-Reply-To: <20080402094923.185f15dc@extreme>
Use netdev_alloc_skb since it handles any NUMA node memory localtion issues
and sets skb->dev. Since device driver was not setting skb->dev, I bet
filter rules based on device would not work.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/sc92031.c 2008-04-02 10:03:00.000000000 -0700
+++ b/drivers/net/sc92031.c 2008-04-02 10:03:04.000000000 -0700
@@ -796,7 +796,7 @@ static void _sc92031_rx_tasklet(struct n
rx_len -= rx_size_align + 4;
- skb = dev_alloc_skb(pkt_size + NET_IP_ALIGN);
+ skb = netdev_alloc_skb(dev, pkt_size + NET_IP_ALIGN);
if (unlikely(!skb)) {
if (printk_ratelimit())
printk(KERN_ERR "%s: Couldn't allocate a skb_buff for a packet of size %u\n",
prev parent reply other threads:[~2008-04-02 17:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-10380-10286@http.bugzilla.kernel.org/>
2008-04-02 16:14 ` [Bugme-new] [Bug 10380] New: sc92031 does not create a device link in sysfs Andrew Morton
2008-04-02 16:39 ` [PATCH] sc92031: sysfs link missing Stephen Hemminger
2008-04-04 5:46 ` Jeff Garzik
2008-04-04 5:52 ` Andrew Morton
2008-04-04 6:40 ` Jeff Garzik
2008-04-02 16:49 ` [Bugme-new] [Bug 10380] New: sc92031 does not create a device link in sysfs Stephen Hemminger
2008-04-02 17:08 ` [PATCH 1/3] sc92031: use net_device stats Stephen Hemminger
2008-04-02 17:08 ` [Bugme-new] [Bug 10380] New: sc92031 does not create a device link in sysfs Thomas Scheiblauer
2008-04-02 17:11 ` [PATCH 2/3] sc92031: start transmit return value bugfix Stephen Hemminger
2008-04-02 17:11 ` [PATCH 1/3] sc92031: use net_device stats Stephen Hemminger
2008-04-12 9:02 ` Jeff Garzik
2008-04-02 17:13 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080402101312.0db8f52e@extreme \
--to=shemminger@vyatta.com \
--cc=cesarb@cesarb.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=tom@sharkbay.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).