From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: xemul@openvz.org, netdev@vger.kernel.org, devel@openvz.org
Subject: Re: [PATCH][VLAN]: Fix egress priority mappings leak.
Date: Fri, 04 Apr 2008 12:45:50 -0700 (PDT) [thread overview]
Message-ID: <20080404.124550.02803879.davem@davemloft.net> (raw)
In-Reply-To: <47F5F8D6.1050204@trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Fri, 04 Apr 2008 11:45:58 +0200
> Pavel Emelyanov wrote:
> > These entries are allocated in vlan_dev_set_egress_priority,
> > but are never released and leaks on vlan device removal.
> >
> > Drop these in vlan's ->uninit callback - after the device is
> > brought down and everyone is notified about it is going to
> > be unregistered.
> >
> > Found during testing vlan netnsization patchset.
> >
> > Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
>
> Good catch, thanks.
>
> Acked-by: Patrick McHardy <kaber@trash.net>
Applied, thanks a lot.
prev parent reply other threads:[~2008-04-04 19:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-04 10:07 [PATCH][VLAN]: Fix egress priority mappings leak Pavel Emelyanov
2008-04-04 9:45 ` Patrick McHardy
2008-04-04 19:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080404.124550.02803879.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).