From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Patrick McHardy <kaber@trash.net>
Cc: dccp@vger.kernel.org, Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [DCCP]: Fix skb->cb conflicts with IP
Date: Fri, 4 Apr 2008 10:26:44 -0300 [thread overview]
Message-ID: <20080404132644.GA5989@ghostprotocols.net> (raw)
In-Reply-To: <47F61B5C.8090105@trash.net>
Em Fri, Apr 04, 2008 at 02:13:16PM +0200, Patrick McHardy escreveu:
> commit eced67957ee99f7b5fafdc73a58bcd037a1789b2
> Author: Patrick McHardy <kaber@trash.net>
> Date: Fri Apr 4 14:10:23 2008 +0200
>
> [DCCP]: Fix skb->cb conflicts with IP
>
> dev_queue_xmit() and the other IP output functions expect to get a skb
> with clear or properly initialized skb->cb. Unlike TCP and UDP, the
> dccp_skb_cb doesn't contain a struct inet_skb_parm at the beginning,
> so the DCCP-specific data is interpreted by the IP output functions.
> This can cause false negatives for the conditional POST_ROUTING hook
> invocation, making the packet bypass the hook.
>
> Add a inet_skb_parm/inet6_skb_parm union to the beginning of
> dccp_skb_cb to avoid clashes. Also add a BUILD_BUG_ON to make
> sure it fits in the cb.
>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
Thanks Patrick,
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
next prev parent reply other threads:[~2008-04-04 13:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-04 12:13 [DCCP]: Fix skb->cb conflicts with IP Patrick McHardy
2008-04-04 13:25 ` Gerrit Renker
2008-04-04 13:40 ` Patrick McHardy
2008-04-04 13:47 ` Arnaldo Carvalho de Melo
2008-04-04 13:26 ` Arnaldo Carvalho de Melo [this message]
2008-04-11 13:41 ` Patrick McHardy
2008-04-11 13:59 ` Gerrit Renker
2008-04-11 14:03 ` Patrick McHardy
2008-04-11 14:05 ` Arnaldo Carvalho de Melo
2008-04-11 18:24 ` David Miller
2008-04-13 1:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080404132644.GA5989@ghostprotocols.net \
--to=acme@redhat.com \
--cc=dccp@vger.kernel.org \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).