netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: 7eggert@gmx.de
Cc: Jeff Garzik <jeff@garzik.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Chris Snook <csnook@redhat.com>,
	Dave Jones <davej@codemonkey.org.uk>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	NetDev <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: GFP_ATOMIC page allocation failures.
Date: Fri, 4 Apr 2008 21:59:53 +1100	[thread overview]
Message-ID: <200804042159.54220.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <E1Jhib4-0000md-FP@be1.7eggert.dyndns.org>

On Friday 04 April 2008 20:52, Bodo Eggert wrote:
> Nick Piggin <nickpiggin@yahoo.com.au> wrote:
> > On Thursday 03 April 2008 05:18, Jeff Garzik wrote:
> >> Turning to Nick's comment,
> >>
> >> > It's still actually nice to know how often it is happening even for
> >> > these known good sites because too much can indicate a problem and
> >> > that you could actually bring performance up by tuning some things.
> >>
> >> then create a counter or acculuation buffer somewhere.
> >>
> >> We don't need spew every time there is memory pressure of this
> >> magnitude.
> >
> > Not a complete solution. Counter would be nice, but you need backtraces
> > and want a way to more proactively warn the user/tester/developer.
> >
> > I agree that I don't exactly like adding nowarns around, and I don't
> > think places like driver writers should have to know about this stuff.
>
> What about reverse ratelimiting: If the limit is reached, a backtrace will
> be generated (and, off cause, positively ratelimited)?

I was thinking about that. I got as far as writing a simple patch to
printk  so that it would not start to trigger until it gets a 2nd event
within 'n' jiffies of the first.

But actually developers do sometimes want see the event even if it is
relatively infrequent...

  reply	other threads:[~2008-04-04 11:00 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <adYyJ-20N-11@gated-at.bofh.it>
     [not found] ` <aef6w-6rx-45@gated-at.bofh.it>
     [not found]   ` <aefJ9-7KR-15@gated-at.bofh.it>
     [not found]     ` <aeqF6-45P-29@gated-at.bofh.it>
2008-04-04  9:52       ` GFP_ATOMIC page allocation failures Bodo Eggert
2008-04-04 10:59         ` Nick Piggin [this message]
2008-04-04 11:35           ` Bodo Eggert
2008-04-05  1:06             ` Nick Piggin
2008-04-06 12:12               ` Bodo Eggert
     [not found] <20080401235609.GA6947@codemonkey.org.uk>
     [not found] ` <200804021228.16875.nickpiggin@yahoo.com.au>
     [not found] ` <47F32789.2070703@redhat.com>
     [not found]   ` <20080402005646.f8df1c1b.akpm@linux-foundation.org>
2008-04-02  8:17     ` KOSAKI Motohiro
2008-04-02  8:24       ` David Miller
2008-04-02  8:43         ` Andrew Morton
2008-04-02 10:00         ` KOSAKI Motohiro
2008-04-02 10:56           ` KOSAKI Motohiro
2008-04-02 18:44             ` David Miller
2008-04-02 20:12               ` Michael Chan
2008-04-02 20:53                 ` David Miller
2008-04-02 11:04         ` Peter Zijlstra
2008-04-02 18:45           ` David Miller
2008-04-02 19:06             ` Jeff Garzik
     [not found]     ` <200804022012.58760.nickpiggin@yahoo.com.au>
2008-04-02 15:54       ` Andrew Morton
2008-04-03  5:22         ` Nick Piggin
2008-04-03  5:32           ` Andrew Morton
2008-04-03  8:59             ` Evgeniy Polyakov
2008-06-26 21:06               ` Dave Jones
2008-06-26 22:26                 ` Chris Snook
2008-06-27 10:01                 ` Evgeniy Polyakov
2008-04-02 17:21     ` Jeff Garzik
2008-04-02 17:33       ` Andrew Morton
2008-04-02 18:18         ` Jeff Garzik
2008-04-02 18:37           ` Kok, Auke
2008-04-03  5:57           ` Nick Piggin
2008-04-03 18:20             ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804042159.54220.nickpiggin@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=7eggert@gmx.de \
    --cc=akpm@linux-foundation.org \
    --cc=csnook@redhat.com \
    --cc=davej@codemonkey.org.uk \
    --cc=davem@davemloft.net \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).