From: Andi Kleen <andi@firstfloor.org>
To: Robert Olsson <Robert.Olsson@data.slu.se>
Cc: Andi Kleen <andi@firstfloor.org>,
Stephen Hemminger <shemminger@vyatta.com>,
David Miller <davem@davemloft.net>,
Eric Dumazet <dada1@cosmosbay.com>,
netdev@vger.kernel.org
Subject: Re: [RFC] fib_trie: memory waste solutions
Date: Mon, 7 Apr 2008 17:15:03 +0200 [thread overview]
Message-ID: <20080407151503.GD16647@one.firstfloor.org> (raw)
In-Reply-To: <18426.13019.345218.79888@robur.slu.se>
On Mon, Apr 07, 2008 at 04:42:35PM +0200, Robert Olsson wrote:
>
> Andi Kleen writes:
>
> > > Do we get slower with vmalloc due to TLB-lookups etc? Guess this
> > > should be investigated.
> >
> > In some cases it might even go faster because a lot of x86 CPUs
> > have far more 4K TLBs than 2M TLBs. vmalloc is just quite expensive
> > in setup/free time, but that shouldn't be a big issue here.
>
>
> I've did some rDoS testing and the lookup performance is the same or
> slightly better. So it should be fine.
If you want more realistic worst case numbers run something in user space in
the background that thrashes the TLBs constantly and then see how
the numbers change.
The main advantage of using large pages is that they tend to be separated
from 4K TLBs and since most user space doesn't use large pages it
gives the kernel an effective private TLB pool.
With vmalloc it will now compete with whatever other TLB pigs are active.
-Andi
next prev parent reply other threads:[~2008-04-07 15:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-02 0:27 [RFC] fib_trie: flush improvement Stephen Hemminger
2008-04-02 8:01 ` Eric Dumazet
2008-04-02 14:35 ` Eric Dumazet
2008-04-02 18:03 ` Stephen Hemminger
2008-04-02 19:36 ` Eric Dumazet
2008-04-04 16:02 ` [RFC] fib_trie: memory waste solutions Stephen Hemminger
2008-04-07 6:55 ` Robert Olsson
2008-04-07 7:58 ` Andi Kleen
2008-04-07 14:42 ` Robert Olsson
2008-04-07 15:15 ` Andi Kleen [this message]
2008-04-07 15:36 ` Eric Dumazet
2008-04-07 16:46 ` Eric Dumazet
2008-04-07 22:48 ` Stephen Hemminger
2008-04-10 9:57 ` David Miller
2008-04-02 9:31 ` [RFC] fib_trie: flush improvement Robert Olsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080407151503.GD16647@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=Robert.Olsson@data.slu.se \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).