From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 5/6] IPV4: route use jhash3
Date: Thu, 10 Apr 2008 01:54:48 -0700 (PDT) [thread overview]
Message-ID: <20080410.015448.00224349.davem@davemloft.net> (raw)
In-Reply-To: <20080401004724.752793269@vyatta.com>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 31 Mar 2008 17:47:13 -0700
> Since route hash is a triple, use jhash_3words rather doing the mixing
> directly. This should be as fast and give better distribution.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied to net-2.6.26, but:
> -static unsigned int rt_hash_code(u32 daddr, u32 saddr)
> +static inline unsigned int rt_hash(__be32 daddr, __be32 saddr, int idx)
Are you sure you want to inline that? jhash expands
to a lot of instructions
next prev parent reply other threads:[~2008-04-10 8:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080401004708.009204033@vyatta.com>
2008-04-01 0:47 ` [PATCH 1/6] socket: sk_filter minor cleanups Stephen Hemminger
2008-04-10 8:39 ` David Miller
2008-04-01 0:47 ` [PATCH 2/6] socket: sk_filter deinline Stephen Hemminger
2008-04-10 8:49 ` David Miller
2008-04-01 0:47 ` [PATCH 3/6] IPV4 : use xor rather than multiple ands for route compare Stephen Hemminger
2008-04-01 5:52 ` Eric Dumazet
2008-04-01 20:08 ` Stephen Hemminger
2008-04-10 8:51 ` David Miller
2008-04-10 9:01 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-10 10:56 ` David Miller
2008-04-10 12:17 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-10 9:26 ` Eric Dumazet
2008-04-10 11:00 ` David Miller
2008-04-01 0:47 ` [PATCH 4/6] IPV4: route inline changes Stephen Hemminger
2008-04-10 8:53 ` David Miller
2008-04-01 0:47 ` [PATCH 5/6] IPV4: route use jhash3 Stephen Hemminger
2008-04-10 8:54 ` David Miller [this message]
2008-04-01 0:47 ` [PATCH 6/6] IPV4: route rekey timer can be deferrable Stephen Hemminger
2008-04-10 8:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080410.015448.00224349.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).