From: David Miller <davem@davemloft.net>
To: xemul@openvz.org
Cc: ralf@linux-mips.org, netdev@vger.kernel.org, linux-hams@vger.kernel.org
Subject: Re: [PATCH][AX25]: Potential ax25_uid_assoc-s leaks on module unload.
Date: Sat, 12 Apr 2008 18:34:01 -0700 (PDT) [thread overview]
Message-ID: <20080412.183401.80819932.davem@davemloft.net> (raw)
In-Reply-To: <4800A598.10506@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Sat, 12 Apr 2008 16:05:44 +0400
> The ax25_uid_free call walks the ax25_uid_list and releases
> entries from it. The problem is that after the fisrt call to
> hlist_del_init the hlist_for_each_entry (which hides behind
> the ax25_uid_for_each) will consider the current position to
> be the last and will return.
>
> Thus, the whole list will be left not freed.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied, thanks Pavel.
prev parent reply other threads:[~2008-04-13 1:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-12 12:05 [PATCH][AX25]: Potential ax25_uid_assoc-s leaks on module unload Pavel Emelyanov
2008-04-13 1:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080412.183401.80819932.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-hams@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).