netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: dmitry@butskoy.name, bugme-daemon@bugzilla.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [Bugme-new] [Bug 10437] New: MSG_ERRQUEUE messages do not pass to connected raw sockets
Date: Sun, 13 Apr 2008 23:15:44 -0700 (PDT)	[thread overview]
Message-ID: <20080413.231544.83437216.davem@davemloft.net> (raw)
In-Reply-To: <20080410103444.d7309e1f.akpm@linux-foundation.org>

From: Andrew Morton <akpm@linux-foundation.org>
Date: Thu, 10 Apr 2008 10:34:44 -0700

> Dmitry, I'd suggest that you send the patch via email to
> netdev@vger.kernel.org and to YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>.

This person is having trouble emailing things to the lists and elsewhere,
for whatever reason, and he states this in the bugzilla entry so asking
him to email a patch somewhere isn't going to help.

The code in this area has changed a bit, here is the patch I just checked
into net-2.6 and which I'll push to Linus for 2.6.25 and will also submit
for the 2.6.24-stable branch.

commit b45e9189c058bfa495073951ff461ee0eea968be
Author: David S. Miller <davem@davemloft.net>
Date:   Sun Apr 13 23:14:15 2008 -0700

    [IPV6]: Fix ipv6 address fetching in raw6_icmp_error().
    
    Fixes kernel bugzilla 10437
    
    Based almost entirely upon a patch by Dmitry Butskoy.
    
    When deciding what raw sockets to deliver the ICMPv6
    to, we should use the addresses in the ICMPv6 quoted
    IPV6 header, not the top-level one.
    
    Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c
index 8897ccf..0a6fbc1 100644
--- a/net/ipv6/raw.c
+++ b/net/ipv6/raw.c
@@ -372,8 +372,10 @@ void raw6_icmp_error(struct sk_buff *skb, int nexthdr,
 	read_lock(&raw_v6_hashinfo.lock);
 	sk = sk_head(&raw_v6_hashinfo.ht[hash]);
 	if (sk != NULL) {
-		saddr = &ipv6_hdr(skb)->saddr;
-		daddr = &ipv6_hdr(skb)->daddr;
+		struct ipv6hdr *hdr = (struct ipv6hdr *) skb->data;
+
+		saddr = &hdr->saddr;
+		daddr = &hdr->daddr;
 		net = skb->dev->nd_net;
 
 		while ((sk = __raw_v6_lookup(net, sk, nexthdr, saddr, daddr,

      parent reply	other threads:[~2008-04-14  6:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-10437-10286@http.bugzilla.kernel.org/>
2008-04-10 17:34 ` [Bugme-new] [Bug 10437] New: MSG_ERRQUEUE messages do not pass to connected raw sockets Andrew Morton
2008-04-11 11:02   ` [PATCH] [IPV6]: bug 10437: " Dmitry Butskoy
2008-04-11 11:12     ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-11 11:39       ` Dmitry Butskoy
2008-04-14  6:15   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080413.231544.83437216.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@linux-foundation.org \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=dmitry@butskoy.name \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).